From dev-return-14389-archive-asf-public=cust-asf.ponee.io@perl.apache.org Thu Sep 26 08:11:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9A4381804BB for ; Thu, 26 Sep 2019 10:11:58 +0200 (CEST) Received: (qmail 19666 invoked by uid 500); 26 Sep 2019 08:11:56 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 19438 invoked by uid 99); 26 Sep 2019 08:11:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Sep 2019 08:11:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9B83F1A341D; Thu, 26 Sep 2019 08:11:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.3 X-Spam-Level: X-Spam-Status: No, score=0.3 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vh2TeSEas50V; Thu, 26 Sep 2019 08:11:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.166.68; helo=mail-io1-f68.google.com; envelope-from=steve.m.hay@googlemail.com; receiver= Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id AD3EFBC725; Thu, 26 Sep 2019 08:02:32 +0000 (UTC) Received: by mail-io1-f68.google.com with SMTP id h144so4108598iof.7; Thu, 26 Sep 2019 01:02:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W7FUQNCr+2UrRNDctAoHrA7WU3BVZqaDqzQf8U+ne20=; b=lpyCMjDT/CwKvKGMrJWjztsYL1azVAb9JWlOw1v1QwIIl4A7IUhX+lYprEMNQ3kReV mYtU1y5363eQ4Ycf/2J12heIpBZw/InY8fvMZpv+t4d6CTxle9gT/Wo7HtMq4RgzrhXt y6acf2fBK/xhaWLJJeide3GbODUAGAuTtkBPg0OCPubSXV5uenh4uvgrh2MshLbvT5ZT 6K6GceNoGqYpDb1RZd3JFS7Fj2oP9XA8tz9z9n99JRVcxaPOJaNVHAvkkf7S6vjkVHoG +3o14EJgklEK8ZYr1Q8dTciC7pvzPaZsoXXBSRykGHHJO5Sbb/E0/VAHOgKsjPzoqkJn es+g== X-Gm-Message-State: APjAAAXJ4+cVTi7rdJOWg1GTOPEwkaMNc7vhDy4TutlLJdm1zlZt7B8U 9q/+0N6HyzIa43sM8Y9EavYMvk2cCXHWungxhu8= X-Google-Smtp-Source: APXvYqzvS9DR+SNbE6rCR7V2oiEUfXvv7lhKOkn9PeEfeJ/daNcRLWbFiVT//f0ZZNa7ChqPKhxnPCFts+h4fqPbemU= X-Received: by 2002:a05:6638:1f5:: with SMTP id t21mr2365325jaq.119.1569484951161; Thu, 26 Sep 2019 01:02:31 -0700 (PDT) MIME-Version: 1.0 References: <38e7f5e7-9b7e-81ea-81c1-64a9275e228c@utoronto.ca> <20190925200656.djoincdljndygv4q@fbd7c150-3361-11e8-8c11-5badabdd4a8d> <20190926055444.ekibi3wdzcppq6lf@fbd7c150-3361-11e8-8c11-5badabdd4a8d> In-Reply-To: <20190926055444.ekibi3wdzcppq6lf@fbd7c150-3361-11e8-8c11-5badabdd4a8d> From: Steve Hay Date: Thu, 26 Sep 2019 09:02:19 +0100 Message-ID: Subject: Re: [RELEASE CANDIDATE] mod_perl-2.0.11 RC2 To: Damyan Ivanov Cc: modperl@perl.apache.org, dev@perl.apache.org Content-Type: multipart/mixed; boundary="000000000000fea8f1059370302b" --000000000000fea8f1059370302b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 26 Sep 2019 at 06:54, Damyan Ivanov wrote: > > -=3D| Damyan Ivanov, 25.09.2019 23:06:56 +0300 |=3D- > > -=3D| Steve Hay, 25.09.2019 08:34:07 +0100 |=3D- > > > What happens if you revert the change in that file? I.e. Change > > > FINFO_NAME back to FINFO_NORM on line 168, and on line 18 (the > > > APR::Const -compile line)? Does that fix it for you? > > > > With these two lines reverted, all tests pass for me. > > Out of interest I also tried using "FINFO_NAME | FINFO_NORM" on line > 168 and the test failed with the same error. It appears that > FINFO_NAME triggers it. > > Tracing this in APR, the error seems to come from > file_io/unix/filestat.c=C2=B9 where the valid flags on line 73 don't > include APR_FINFO_NAME. This kind of makes sense, because the stat(2) > struct lacks information about the file name. > > =C2=B9 https://sources.debian.org/src/apr/1.6.5-1/file_io/unix/filestat.= c/ > > -- Damyan Good catch! That explains why using FINFO_NAME is failing for you but working for me (on Windows): apr/file_io/win32/filestat.c *does* have support for FINFO_NAME in it, filling in finfo->name from filename if it succeeded in getting filename (using calls other than stat()!). The point of the request_rec test in question is only to test a single field anyway (the rest are tested in TestAPR::finfo, as the comment says) so I will simply change it to test a different field. Evidently FINFO_NAME was a poor choice! Before I actually roll out an RC3, please can you confirm that switching to FINFO_SIZE as per this patch works for you (it does for me): Index: t/response/TestAPI/request_rec.pm =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- t/response/TestAPI/request_rec.pm (revision 1866274) +++ t/response/TestAPI/request_rec.pm (working copy) @@ -15,7 +15,7 @@ use APR::Pool (); use Apache2::Const -compile =3D> qw(OK M_GET M_PUT); -use APR::Const -compile =3D> qw(FINFO_NAME); +use APR::Const -compile =3D> qw(FINFO_SIZE); #this test module is only for testing fields in the request_rec #listed in apache_structures.map @@ -165,12 +165,13 @@ # finfo { - my $finfo =3D APR::Finfo::stat(__FILE__, APR::Const::FINFO_NAME, $r->pool); + my $size =3D (stat __FILE__)[7]; + my $finfo =3D APR::Finfo::stat(__FILE__, APR::Const::FINFO_SIZE, $r->pool); $r->finfo($finfo); # just one field test, all accessors are fully tested in # TestAPR::finfo - ok t_cmp($r->finfo->fname, - __FILE__, + ok t_cmp($r->finfo->size, + $size, '$r->finfo'); } --000000000000fea8f1059370302b Content-Type: application/octet-stream; name="request_rec.patch" Content-Disposition: attachment; filename="request_rec.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k10escld0 SW5kZXg6IHQvcmVzcG9uc2UvVGVzdEFQSS9yZXF1ZXN0X3JlYy5wbQ0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t IHQvcmVzcG9uc2UvVGVzdEFQSS9yZXF1ZXN0X3JlYy5wbQkocmV2aXNpb24gMTg2NjI3NCkNCisr KyB0L3Jlc3BvbnNlL1Rlc3RBUEkvcmVxdWVzdF9yZWMucG0JKHdvcmtpbmcgY29weSkNCkBAIC0x NSw3ICsxNSw3IEBADQogdXNlIEFQUjo6UG9vbCAoKTsKIAogdXNlIEFwYWNoZTI6OkNvbnN0IC1j b21waWxlID0+IHF3KE9LIE1fR0VUIE1fUFVUKTsKLXVzZSBBUFI6OkNvbnN0ICAgIC1jb21waWxl ID0+IHF3KEZJTkZPX05BTUUpOwordXNlIEFQUjo6Q29uc3QgICAgLWNvbXBpbGUgPT4gcXcoRklO Rk9fU0laRSk7CiAKICN0aGlzIHRlc3QgbW9kdWxlIGlzIG9ubHkgZm9yIHRlc3RpbmcgZmllbGRz IGluIHRoZSByZXF1ZXN0X3JlYwogI2xpc3RlZCBpbiBhcGFjaGVfc3RydWN0dXJlcy5tYXAKQEAg LTE2NSwxMiArMTY1LDEzIEBADQogCiAgICAgIyBmaW5mbwogICAgIHsKLSAgICAgICAgbXkgJGZp bmZvID0gQVBSOjpGaW5mbzo6c3RhdChfX0ZJTEVfXywgQVBSOjpDb25zdDo6RklORk9fTkFNRSwg JHItPnBvb2wpOworICAgICAgICBteSAkc2l6ZSA9IChzdGF0IF9fRklMRV9fKVs3XTsKKyAgICAg ICAgbXkgJGZpbmZvID0gQVBSOjpGaW5mbzo6c3RhdChfX0ZJTEVfXywgQVBSOjpDb25zdDo6RklO Rk9fU0laRSwgJHItPnBvb2wpOwogICAgICAgICAkci0+ZmluZm8oJGZpbmZvKTsKICAgICAgICAg IyBqdXN0IG9uZSBmaWVsZCB0ZXN0LCBhbGwgYWNjZXNzb3JzIGFyZSBmdWxseSB0ZXN0ZWQgaW4K ICAgICAgICAgIyBUZXN0QVBSOjpmaW5mbwotICAgICAgICBvayB0X2NtcCgkci0+ZmluZm8tPmZu YW1lLAotICAgICAgICAgICAgICAgICBfX0ZJTEVfXywKKyAgICAgICAgb2sgdF9jbXAoJHItPmZp bmZvLT5zaXplLAorICAgICAgICAgICAgICAgICAkc2l6ZSwKICAgICAgICAgICAgICAgICAgJyRy LT5maW5mbycpOwogICAgIH0KIAo= --000000000000fea8f1059370302b Content-Type: text/plain; charset=us-ascii --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org --000000000000fea8f1059370302b--