Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <2fbf1964-d007-acbe-075d-d41a710e7e52@kippdata.de>
References: <2fbf1964-d007-acbe-075d-d41a710e7e52@kippdata.de>
From: Steve Hay <steve.m.hay@googlemail.com>
Date: Wed, 4 Jan 2017 13:54:23 +0000
Message-ID: <CADED=K4efR-0BKA__EEkGz5DEDDePGh4RngJ4NTFfQKuBJLAQQ@mail.gmail.com>
Subject: Re: svn commit: r1717474 - in /perl/modperl/trunk: Changes
 src/modules/perl/mod_perl.c src/modules/perl/modperl_env.c
 src/modules/perl/modperl_env.h src/modules/perl/modperl_perl.c t/response/TestModperl/env.pm
To: Rainer Jung <rainer.jung@kippdata.de>
Cc: modperl-cvs@perl.apache.org, dev@perl.apache.org
Content-Type: multipart/mixed; boundary=001a114e2bde50b4120545451f0c
archived-at: Wed, 04 Jan 2017 13:54:29 -0000

--001a114e2bde50b4120545451f0c
Content-Type: text/plain; charset=UTF-8

On 4 January 2017 at 13:27, Rainer Jung <rainer.jung@kippdata.de> wrote:
> Hi there,
>
> this commit broke compatibility for mod_perl 2.0.10 with perl before version
> 5.14. AFAIK API function mg_free_type() used here was only introduced in
> 5.14.0. Since the above commit was titled "Add support for Perl 5.22.x.", it
> might be possible to fix this using a version dependent code path. But I
> don't know enough about these internals to suggest an appropriate patch,
> sorry.
>

Thanks for the report.

Are you in a position to try the attached patch, which I think should
be sufficient to fix it? (mg_free() removes magic of all types, but I
wouldn't expect any magic other than the type targetted by the
mg_free_type() call to be present anyway.)

If not then I'll build a 5.14 and try it myself, but I don't have one
to hand at the moment.

--001a114e2bde50b4120545451f0c
Content-Type: text/x-diff; charset=US-ASCII; name="mg_free.patch"
Content-Disposition: attachment; filename="mg_free.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ixj088mm0

SW5kZXg6IHNyYy9tb2R1bGVzL3BlcmwvbW9kcGVybF9lbnYuYw0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHNy
Yy9tb2R1bGVzL3BlcmwvbW9kcGVybF9lbnYuYwkocmV2aXNpb24gMTc3NzMwOSkNCisrKyBzcmMv
bW9kdWxlcy9wZXJsL21vZHBlcmxfZW52LmMJKHdvcmtpbmcgY29weSkNCkBAIC02NzAsNyArNjcw
LDExIEBADQogICAgICAgICAgICAgICAgbWctPm1nX3B0ciwgbWctPm1nX29iaiwgbWctPm1nX2Zs
YWdzKTsKIAogICAgIC8qIFJlbW92ZSBpdCAqLworI2lmIE1QX1BFUkxfVkVSU0lPTl9BVF9MRUFT
VCg1LCAxMywgNikKICAgICBtZ19mcmVlX3R5cGUoKFNWKilFTlZIViwgUEVSTF9NQUdJQ19lbnYp
OworI2Vsc2UKKyAgICBtZ19mcmVlKChTViopRU5WSFYpOworI2VuZGlmCiAKICAgICAvKiBBZGQg
b3VyIHZlcnNpb24gaW5zdGVhZCAqLwogICAgIG1nID0gc3ZfbWFnaWNleHQoKFNWKilFTlZIViwg
KFNWKilOVUxMLCBQRVJMX01BR0lDX2VudiwgJk1QX3Z0YmxfZW52LCAoY2hhciopTlVMTCwgMCk7
CkBAIC02OTksNyArNzAzLDExIEBADQogICAgICAgICAgICAgICAgbWctPm1nX3B0ciwgbWctPm1n
X29iaiwgbWctPm1nX2ZsYWdzKTsKIAogICAgIC8qIFJlbW92ZSBpdCAqLworI2lmIE1QX1BFUkxf
VkVSU0lPTl9BVF9MRUFTVCg1LCAxMywgNikKICAgICBtZ19mcmVlX3R5cGUoKFNWKilFTlZIViwg
UEVSTF9NQUdJQ19lbnYpOworI2Vsc2UKKyAgICBtZ19mcmVlKChTViopRU5WSFYpOworI2VuZGlm
CiAKICAgICAvKiBSZXN0b3JlIHBlcmwncyBvcmlnaW5hbCB2ZXJzaW9uICovCiAgICAgc3ZfbWFn
aWNleHQoKFNWKilFTlZIViwgKFNWKilOVUxMLCBQRVJMX01BR0lDX2VudiwgJlBMX3Z0YmxfZW52
LCAoY2hhciopTlVMTCwgMCk7Cg==

--001a114e2bde50b4120545451f0c
Content-Type: text/plain; charset=us-ascii


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
--001a114e2bde50b4120545451f0c--