perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steve Hay <steve.m....@googlemail.com>
Subject Re: [RELEASE CANDIDATE]: mod_perl-2.0.9 RC2
Date Tue, 09 Jun 2015 08:23:49 GMT
On 8 June 2015 at 08:14, Jan Kalu┼ża <jkaluza@redhat.com> wrote:
> On 05/31/2015 03:12 AM, Kevin A. McGrail wrote:
>>
>> On 5/30/2015 2:20 PM, Steve Hay wrote:
>>>
>>> Please download, test, and report back on this release candidate of
>>> the long-awaited mod_perl 2.0.9.
>>>
>>> http://people.apache.org/~stevehay/mod_perl-2.0.9-rc2.tar.gz
>>>
>>> MD5 = 6dbf61e0724a245f1c015687fb3e4213
>>> SHA1 = faf63c98b338ef0373ccbbe775c52506270ff3b9
>>>
>>> Changes since RC1:
>>>
>>> Remove PerlInterpScope. This has not been working properly with
>>> threaded MPMs with httpd-2.4.x and the use-case of this directive was
>>> questionable. [Jan Kaluza]
>>>
>>> Allow running the test suite with httpd-2.4.x when mod_access_compat
>>> is not loaded. [Steve Hay]
>>
>> The test suite finished with one failure against 2.4.12 on my test rig:
>>
>> Test Summary Report
>> -------------------
>> t/api/aplog.t                         (Wstat: 0 Tests: 36 Failed: 1)
>>    Failed test:  24
>> Files=245, Tests=4646, 304 wallclock secs ( 3.34 usr  0.49 sys + 227.74
>> cusr 50.53 csys = 282.10 CPU)
>> Result: FAIL
>> Failed 1/245 test programs. 1/4646 subtests failed.
>> [warning] server localhost.localdomain:8529 shutdown
>> [warning] port 8529 still in use...
>> ...done
>> [  error] error running tests (please examine t/logs/error_log)
>> +--------------------------------------------------------+
>> | Please file a bug report: http://perl.apache.org/bugs/ |
>> +--------------------------------------------------------+
>> Makefile:1112: recipe for target 'run_tests' failed
>> make: *** [run_tests] Error 1
>>
>>
>>
>> Repeating with TEST_VERBOSE=1 added...  Here's the relevant output:
>>
>> ok 23
>> # testing : $s->log_serror(LOG_MARK, LOG_DEBUG, APR::Const::EGENERAL...)
>> # expected: qr/(?^:Internal error: log_serror test 2)/
>> # received: '
>> # *** The following warn entry is expected and harmless ***
>> # [Sat May 30 21:04:59.085379 2015] [perl:debug] [pid 9642:tid 3076]
>> aplog.pm(90): (20014)Internal error (specific information not
>> available): log_serror test 2
>> # '
>> not ok 24
>> # testing : $r->log_rerror(LOG_MARK, LOG_CRIT, APR::Const::ENOTIME...)
>> # expected: qr/(?^:\[\w*:crit\] \[pid[^]]+\] .*?: \[[^]]+\] log_rerror
>> test)/
>> # received: '# Failed test 24 in
>> /usr/src/mod_perl-2.0.9-rc2/t/response/TestAPI/aplog.pm at line 92
>
>
> Something is bad here I think, because test on line 92 is not the one which
> is failing according to the TEST_VERBOSE output. Could you check what's in
> aplog.pm at line 92?
>
> Jan Kaluza
>
>> # *** The following error entry is expected and harmless ***
>> # [Sat May 30 21:04:59.086325 2015] [perl:crit] [pid 9642:tid 3076]
>> (20007)No time was provided and one was required.: [client
>> 127.0.0.1:56778] log_rerror test
>> # '
>> ok 25

Ah... I think the "testing/expected/received" text is appearing
*before* the "ok/not ok" text.

Test 25 has succeeded because the quoted text from "# Failed test 24"
through "log_rerror test #" does indeed match the pattern
qr/\[\w*:crit\] \[pid[^]]+\] .*?: \[[^]]+\] log_rerror test/

But it is test 24 on lin 92 that has failed because the received text

# *** The following warn entry is expected and harmless ***
# [Sat May 30 21:04:59.085379 2015] [perl:debug] [pid 9642:tid 3076]
aplog.pm(90): (20014)Internal error (specific information not
available): log_serror test 2
#

doesn't match the pattern qr/$egeneral: log_serror test 2/, where

        my $egeneral = have_min_apache_version('2.1.0')
           ? "Internal error"
           : "Error string not specified yet";

It fails to match because of the " (specific information not available)" part.

Does the following/attached patch fix it?

Index: t/response/TestAPI/aplog.pm
===================================================================
--- t/response/TestAPI/aplog.pm (revision 1684346)
+++ t/response/TestAPI/aplog.pm (working copy)
@@ -83,7 +83,7 @@

         # the APR_EGENERAL error string changed for APR 1.0
         my $egeneral = have_min_apache_version('2.1.0')
-           ? "Internal error"
+           ? qr/Internal error(?: \(specific information not available\))?/
            : "Error string not specified yet";

         t_server_log_warn_is_expected();

Mime
View raw message