perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niko Tyni <nt...@debian.org>
Subject Re: Bug#697682: libapache2-mod-perl2: Intermittent FTBFS: t/apache/read3.t failure
Date Fri, 05 Sep 2014 19:06:43 GMT
On Wed, Aug 13, 2014 at 11:47:58AM +0300, Niko Tyni wrote:
> On Wed, Aug 13, 2014 at 09:12:11AM +0100, Steve Hay wrote:
> 
> > Thanks for the patch. I haven't seen this failure myself on Windows,
> > but the patch certainly doesn't seem to break anything. I'm a little
> > uneasy about it, though. It seems odd to structure read3.pm
> > differently to read2.pm and read4.pm, which still have a plan emitted
> > before the first read().
> > 
> > Why does read3.pm deadlock but read2.pm and read4.pm don't? If it's
> > just luck then perhaps read2.pm and read4.pm should be changed
> > similarly?
> 
> It only happens with read3 because the POSTed string in that test is
> very much larger than the other ones. LWP::Protocol::http sends the
> whole POST request in one write() unless it's over eight kilobytes long
> (see lib/LWP/Protocol/http.pm in libwww-perl_6.08 line 276.)

I've updated the attached patch to change read2 too. read4 is quite
different though, as it reads just a few bytes at a time, so I think
it's OK to leave it as is.

> > Maybe a comment in the code would be good too, since the structure of
> > most test files is to get the plan out early. Otherwise there is scope
> > for re-introducing the bug in the future since it isn't obvious that
> > the placement of the plan is important.

Done as well.

Thanks again,
-- 
Niko Tyni   ntyni@debian.org

Mime
View raw message