perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Hay" <Steve....@verosoftware.com>
Subject RE: [httpd24 branch] apr-ext crashes
Date Mon, 29 Jul 2013 14:59:40 GMT
Jan Kalu┼ża wrote on 2013-07-29:
> On 07/29/2013 10:54 AM, Steve Hay wrote:
>> Ok, I've found the problem: Apache2::Build::apr_generation() is now
> returning 2 instead of 1, but the apxs scripts on Windows are still
> called ap[ru]-1-config.bat.
>> 
>> I could easily tweak apr_generation() to account for that, but I
> guess the correct fix is to change apxs on Windows?
> 
> Hm, I build it with following options on Linux, so I presume it skips
> this check:
>           MP_APXS=/usr/bin/apxs \
>           MP_APR_CONFIG=%{_bindir}/apr-1-config
> After discussion with Joe Orton I think it would be better to use APR
> generation 1 even for httpd-2.4, so the proper fix would be to change
> apr_generation() method to return 1. Httpd-2.4 is still intended to be
> compiled with APR-1.x. Maybe in the past it was not like that and
> therefore we have that code there, but current state is like I said.
> 

Ok, with revs 1222775 (apr_generation() change), 1448043 and 1503135 (aprutil-1 changes) all
reverted the build now works for me and the apr-ext tests no longer crash. The attached patch
effects these three reverts.

Does this work for you? It reverts the "FIXME" for finding aprutil-1 which you added in rev
1448043, but I wonder if that was unnecessary?:- Maybe if you don't pass MP_APR_CONFIG then
it will work fine for you, given that apr_generation() now does the right thing? Or failing
that, passing MP_APU_CONFIG as well should locate aprutil-1?

If these changes are ok then I will commit them and continue looking at what else is wrong
here on Windows...

I still have the problem of needing to put the httpd bin and mod_perl.so paths in my PATH,
plus I need to pull in the latest Apache-Test changes (specifically, rev 1504090) for the
httpd.conf generation to work correctly. How do I pull that into modperl?

Otherwise, my test failure list is now down to:

Test Summary Report
-------------------
t\apache\subprocess.t                 (Wstat: 0 Tests: 1 Failed: 0)
  Parse errors: Bad plan.  You planned 5 tests but ran 1.
t\api\access2_24.t                    (Wstat: 0 Tests: 6 Failed: 3)
  Failed tests:  2, 5-6
t\api\err_headers_out.t               (Wstat: 0 Tests: 6 Failed: 3)
  Failed tests:  2-3, 5
t\compat\conn_rec.t                   (Wstat: 0 Tests: 2 Failed: 0)
  Parse errors: Bad plan.  You planned 4 tests but ran 2.
t\hooks\authen_digest.t               (Wstat: 0 Tests: 7 Failed: 4)
  Failed tests:  4-7
t\modperl\local_env.t                 (Wstat: 0 Tests: 6 Failed: 1)
  Failed test:  6
t\modperl\merge.t                     (Wstat: 0 Tests: 10 Failed: 3)
  Failed tests:  3, 6, 9
t\modperl\merge2.t                    (Wstat: 0 Tests: 10 Failed: 3)
  Failed tests:  3, 6, 9
t\modperl\merge3.t                    (Wstat: 0 Tests: 10 Failed: 3)
  Failed tests:  3, 6, 9
t\modperl\setupenv2.t                 (Wstat: 0 Tests: 23 Failed: 7)
  Failed tests:  17-23
t\modules\cgi.t                       (Wstat: 0 Tests: 5 Failed: 5)
  Failed tests:  1-5
t\modules\cgi2.t                      (Wstat: 0 Tests: 5 Failed: 5)
  Failed tests:  1-5
t\modules\cgipost.t                   (Wstat: 0 Tests: 6 Failed: 5)
  Failed tests:  2-6
t\modules\cgipost2.t                  (Wstat: 0 Tests: 6 Failed: 5)
  Failed tests:  2-6
t\modules\cgiupload.t                 (Wstat: 0 Tests: 2 Failed: 2)
  Failed tests:  1-2
t\modules\cgiupload2.t                (Wstat: 0 Tests: 2 Failed: 2)
  Failed tests:  1-2
t\protocol\echo_block.t               (Wstat: 0 Tests: 3 Failed: 2)
  Failed tests:  2-3
t\protocol\echo_nonblock.t            (Wstat: 0 Tests: 3 Failed: 1)
  Failed test:  2
t\protocol\echo_timeout.t             (Wstat: 0 Tests: 5 Failed: 4)
  Failed tests:  2-5
t\protocol\pseudo_http.t              (Wstat: 0 Tests: 13 Failed: 9)
  Failed tests:  3-8, 11-13
Files=249, Tests=2468, 801 wallclock secs ( 2.15 usr +  0.28 sys =  2.43 CPU)
Result: FAIL
Failed 20/249 test programs. 67/2468 subtests failed.
Mime
View raw message