Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of ntyni@cc.helsinki.fi designates
 128.214.173.75 as permitted sender)
Date: Sun, 30 Jun 2013 23:19:08 +0300
From: Niko Tyni <ntyni@debian.org>
To: dev@perl.apache.org
Subject: Re: [httpd24] t/directive/perlloadmodule3.t failure
Message-ID: <20130630201908.GA5547@madeleine.local.invalid>
References: <20130623202139.GA6317@madeleine.local.invalid>
 <51C829F6.5030800@redhat.com>
 <20130624211441.GB4875@madeleine.local.invalid>
 <51C9607C.6070205@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <51C9607C.6070205@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jun 25, 2013 at 11:18:52AM +0200, Jan Kaluža wrote:
> On 06/24/2013 11:14 PM, Niko Tyni wrote:
> >On Mon, Jun 24, 2013 at 01:13:58PM +0200, Jan Kaluža wrote:
> >>On 06/23/2013 10:21 PM, Niko Tyni wrote:
> >
> >>>># Failed test 1 in t/directive/perlloadmodule3.t at line 38
> >
> >>>  http://svn.apache.org/viewvc/httpd/httpd/trunk/include/httpd.h?r1=959392&r2=959464
> >>>
> >>>Clearly mod_perl2 needs to somehow map the char to a Perl number. The
> >>>test failure happens because the zero byte "\0" is true in Perl and
> >>>so the is_virtual method always returns true.
> >
> >>Try it with attached patch. I haven't tried to run the tests with
> >>the patch applied, but from the generated code it looks like it
> >>should return int now.
> >
> >Thanks, but that doesn't quite work here:

> Hm, I have just tried it and it works for me here (fails without
> this patch and works with it). Have you regenerated xs using "make
> source_scan" and "make xs_generate"?

I thought I had, but obviously something went wrong.

I can confirm it's working for me now. Thanks, and sorry
for being hasty.
-- 
Niko Tyni   ntyni@debian.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org