Return-Path: X-Original-To: apmail-perl-dev-archive@www.apache.org Delivered-To: apmail-perl-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B9F60D556 for ; Mon, 24 Jun 2013 21:15:17 +0000 (UTC) Received: (qmail 80668 invoked by uid 500); 24 Jun 2013 21:15:17 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 80604 invoked by uid 500); 24 Jun 2013 21:15:17 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 80597 invoked by uid 99); 24 Jun 2013 21:15:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jun 2013 21:15:17 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ntyni@cc.helsinki.fi designates 128.214.173.75 as permitted sender) Received: from [128.214.173.75] (HELO smtp-rs1-vallila2.fe.helsinki.fi) (128.214.173.75) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jun 2013 21:15:10 +0000 Received: from madeleine.local.invalid (hy-vpn2-231.vpn.helsinki.fi [128.214.129.231]) by smtp-rs1.it.helsinki.fi (8.14.4/8.14.4) with ESMTP id r5OLEgqL008160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 25 Jun 2013 00:14:49 +0300 Received: from niko by madeleine.local.invalid with local (Exim 4.80) (envelope-from ) id 1UrE5x-0001p1-6Y for dev@perl.apache.org; Tue, 25 Jun 2013 00:14:41 +0300 Date: Tue, 25 Jun 2013 00:14:41 +0300 From: Niko Tyni To: dev@perl.apache.org Subject: Re: [httpd24] t/directive/perlloadmodule3.t failure Message-ID: <20130624211441.GB4875@madeleine.local.invalid> References: <20130623202139.GA6317@madeleine.local.invalid> <51C829F6.5030800@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <51C829F6.5030800@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Checked: Checked by ClamAV on apache.org On Mon, Jun 24, 2013 at 01:13:58PM +0200, Jan Kaluža wrote: > On 06/23/2013 10:21 PM, Niko Tyni wrote: > >># Failed test 1 in t/directive/perlloadmodule3.t at line 38 > > http://svn.apache.org/viewvc/httpd/httpd/trunk/include/httpd.h?r1=959392&r2=959464 > > > >Clearly mod_perl2 needs to somehow map the char to a Perl number. The > >test failure happens because the zero byte "\0" is true in Perl and > >so the is_virtual method always returns true. > Try it with attached patch. I haven't tried to run the tests with > the patch applied, but from the generated code it looks like it > should return int now. Thanks, but that doesn't quite work here: t/directive/perlloadmodule3.t .. 1/3 # Failed test 1 in t/directive/perlloadmodule3.t at line 38 # Failed test 2 in t/directive/perlloadmodule3.t at line 69 # Failed test 3 in t/directive/perlloadmodule3.t at line 97 t/directive/perlloadmodule3.t .. Failed 3/3 subtests t/directive/perlloadmodule4.t .. Failed 3/3 subtests t/directive/perlloadmodule5.t .. Failed 3/3 subtests t/directive/perlloadmodule6.t .. Failed 3/3 subtests Will look into it properly later. -- Niko Tyni ntyni@debian.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org