Return-Path: X-Original-To: apmail-perl-dev-archive@www.apache.org Delivered-To: apmail-perl-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 12213C17C for ; Tue, 18 Jun 2013 19:45:16 +0000 (UTC) Received: (qmail 91283 invoked by uid 500); 18 Jun 2013 19:45:15 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 91253 invoked by uid 500); 18 Jun 2013 19:45:15 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 91246 invoked by uid 99); 18 Jun 2013 19:45:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 19:45:15 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ntyni@cc.helsinki.fi designates 128.214.173.75 as permitted sender) Received: from [128.214.173.75] (HELO smtp-rs1-vallila2.fe.helsinki.fi) (128.214.173.75) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 19:45:09 +0000 Received: from madeleine.local.invalid (hy-vpn2-199.vpn.helsinki.fi [128.214.129.199]) by smtp-rs1.it.helsinki.fi (8.14.4/8.14.4) with ESMTP id r5IJimdX026379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 18 Jun 2013 22:44:49 +0300 Received: from niko by madeleine.local.invalid with local (Exim 4.80) (envelope-from ) id 1Up1pg-0003Kd-Hd for dev@perl.apache.org; Tue, 18 Jun 2013 22:44:48 +0300 Date: Tue, 18 Jun 2013 22:44:48 +0300 From: Niko Tyni To: dev@perl.apache.org Subject: [PATCH] Honour APACHE_TEST_EXTRA_ARGS Message-ID: <20130618194448.GA18413@madeleine.local.invalid> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Checked: Checked by ClamAV on apache.org --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Apache-Test 1.13 introduced the APACHE_TEST_EXTRA_ARGS make variable "to allow passing extra arguments from the command line", but the mod_perl Makefile itself was never modified use that. The attached proposed patch tries to rectify this. We're using APACHE_TEST_EXTRA_ARGS in Debian to run the test suite in package builds with a controlled httpd config instead of relying on the system one (which may not have all the necessary Apache modules enabled, for instance.) -- Niko Tyni ntyni@debian.org --Dxnq1zWXvFF0Q93v Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Honour-APACHE_TEST_EXTRA_ARGS.patch" >From 33962b95d064401f36c82e5f03bcaa898fe696f7 Mon Sep 17 00:00:00 2001 From: Niko Tyni Date: Tue, 18 Jun 2013 21:48:37 +0300 Subject: [PATCH] Honour APACHE_TEST_EXTRA_ARGS Apache-Test 1.13 introduced the APACHE_TEST_EXTRA_ARGS make variable "to allow passing extra arguments from the command line", but the mod_perl Makefile itself was never modified use that. --- Makefile.PL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 132d194..ad55629 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -788,12 +788,12 @@ TEST_FILES = test_clean : $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \ - t/TEST -clean + t/TEST $(APACHE_TEST_EXTRA_ARGS) -clean run_tests : test_clean $(PASSENV) \ $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \ - t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES) + t/TEST $(APACHE_TEST_EXTRA_ARGS) -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES) run_subtests :: cd ModPerl-Registry && $(MAKE) test -- 1.7.10.4 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org --Dxnq1zWXvFF0Q93v--