perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Kaluža <jkal...@redhat.com>
Subject Re: [httpd24] t/directive/perlloadmodule3.t failure
Date Tue, 25 Jun 2013 09:18:52 GMT
On 06/24/2013 11:14 PM, Niko Tyni wrote:
> On Mon, Jun 24, 2013 at 01:13:58PM +0200, Jan Kaluža wrote:
>> On 06/23/2013 10:21 PM, Niko Tyni wrote:
>
>>>> # Failed test 1 in t/directive/perlloadmodule3.t at line 38
>
>>>   http://svn.apache.org/viewvc/httpd/httpd/trunk/include/httpd.h?r1=959392&r2=959464
>>>
>>> Clearly mod_perl2 needs to somehow map the char to a Perl number. The
>>> test failure happens because the zero byte "\0" is true in Perl and
>>> so the is_virtual method always returns true.
>
>> Try it with attached patch. I haven't tried to run the tests with
>> the patch applied, but from the generated code it looks like it
>> should return int now.
>
> Thanks, but that doesn't quite work here:
>   t/directive/perlloadmodule3.t .. 1/3 # Failed test 1 in t/directive/perlloadmodule3.t
at line 38
>   # Failed test 2 in t/directive/perlloadmodule3.t at line 69
>   # Failed test 3 in t/directive/perlloadmodule3.t at line 97
>   t/directive/perlloadmodule3.t .. Failed 3/3 subtests
>   t/directive/perlloadmodule4.t .. Failed 3/3 subtests
>   t/directive/perlloadmodule5.t .. Failed 3/3 subtests
>   t/directive/perlloadmodule6.t .. Failed 3/3 subtests
>
> Will look into it properly later.

Hm, I have just tried it and it works for me here (fails without this 
patch and works with it). Have you regenerated xs using "make 
source_scan" and "make xs_generate"?

Regards,
Jan Kaluza



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message