perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niko Tyni <nt...@debian.org>
Subject Re: [PATCH] Apache-Test: Fall back to SYSCONFDIR if PREFIX is not set
Date Mon, 24 Jun 2013 20:52:24 GMT
On Mon, Jun 24, 2013 at 12:37:56PM +0100, Joe Orton wrote:
> On Tue, Jun 18, 2013 at 09:43:10PM +0300, Niko Tyni wrote:
> > Debian and Ubuntu packaged versions of Apache2 don't define PREFIX,
> > so 'make test' output is filled with warnings like
> >  APXS (/usr/bin/apxs2) query for PREFIX failed
> 
> OK - devil's advocate time.  That's a packaging bug, so the test 
> *should* fail.  Convince me otherwise?

Thanks for looking at this. Side note: the tests don't fail, they are
just filled with warnings. So the PREFIX information doesn't seem to be
all that necessary?

First, the apxs docs at
 http://httpd.apache.org/docs/2.2/programs/apxs.html
actually include a list of allowed -q parameters; quoting:

  The query parameters can be one or more of the following strings: CC,
  CFLAGS, CFLAGS_SHLIB, INCLUDEDIR, LD_SHLIB, LDFLAGS_SHLIB, LIBEXECDIR,
  LIBS_SHLIB, SBINDIR, SYSCONFDIR, TARGET.

This doesn't include PREFIX. So why does Apache-Test think it's allowed to
query that at all? :) Is the availability of PREFIX documented somewhere?

Second, I see this in the Apache-Test changelog:

  =item 1.06 - November 10, 2003
  [...]
  use apxs PREFIX to resolve relative httpd.conf directives
  ServerRoot is not present [Mike Cramer]

Why is PREFIX more appropriate than SYSCONFDIR for this purpose?  Does
Apache actually look in PREFIX before SYSCONFDIR when resolving relative
file names? (I suppose I can check this if you think it really matters.)

Third, if we do consider the lack of PREFIX a bug in the Debian apache2
package, it's a long standing one. I can reproduce it on Debian lenny,
squeeze and wheezy, so it's been this way at least since 2009, probably
longer (I didn't test older releases.) I suspect that many more Ubuntu
releases have the same bug, but I only tried the latest one, 13.04.

I'd expect it to be in the interest of Apache-Test to work on as many
platforms as possible, even slightly buggy ones. The workaround I'm
proposing for the bug isn't very onerous. Is it really the job of
Apache-Test to guard the purity of Apache installations and loudly
complain on those it doesn't deem worthy?
-- 
Niko Tyni   ntyni@debian.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message