Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (athena.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: <9496324.XXJrp84IX2@opi.home>
References: 
 <CAHrynWC47oKNFP-b514ELo4pLOMS0bUPJ+EOL7jCrS1dvfp60Q@mail.gmail.com>
	<5131378.OE8j7cmkIZ@opi.home>
	<4835408.ofL0EQSRla@opi.home>
	<9496324.XXJrp84IX2@opi.home>
Date: Fri, 10 Feb 2012 10:36:57 -0800
Message-ID: 
 <CAHrynWBQVyBrs-_C_5-JDvM3hFODuqmmuqFjdT_NdWP6P4DZ3A@mail.gmail.com>
Subject: Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1
From: Fred Moyer <fred@redhotpenguin.com>
To: =?ISO-8859-1?Q?Torsten_F=F6rtsch?= <torsten.foertsch@gmx.net>
Cc: dev@perl.apache.org, Steve Hay <SteveHay@planit.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

> Meanwhile, I have reverted change 1145161 in trunk.>> Fred, could you ple=
ase roll another rc?
I didn't see the commit message, but verified 'svn update' resulted in a ch=
ange.

Should we add a Changes entry for this?  I'll roll another rc tonight
or tomorrow.  Thanks for the work on this guys.
2012/2/10 Torsten F=F6rtsch <torsten.foertsch@gmx.net>:
> On Tuesday, 07 February 2012 18:01:50 Torsten F=F6rtsch wrote:
>> What to do now? I'd suggest to revert change 1145161 and get 2.0.6 out
>> (perhaps with Steve's latest patch). Steve, do you use perl 5.14? If
>> yes, can you try if you see the "panic: free from wrong pool" also with
>> 5.12?
> On Wednesday, 08 February 2012 09:33:52 Steve Hay wrote:
>> I think my patch is good, but clearly isn't the whole story.
>
> By now I think Steve's patch should not be necessary. I believe the wrong
> context is a result of using the wrong interpreter pool in the directory
> merge.
>
> I think it is a bug if at that point aTHX differs from PERL_GET_CONTEXT. =
So, I
> added the following macros to the threading branch.
>
> #ifdef MP_DEBUG
> # =A0define MP_ASSERT(exp) ap_assert(exp)
> #else
> # =A0define MP_ASSERT(exp) ((void)0)
> #endif
>
> #ifdef USE_ITHREADS
> # =A0define MP_ASSERT_CONTEXT(perl) MP_ASSERT((perl) =3D=3D PERL_GET_CONT=
EXT)
> #else
> # =A0define MP_ASSERT_CONTEXT(perl) ((void)0)
> #endif
>
> The latter macro is then used in modperl_module_config_obj_cleanup() to c=
heck
> the context:
>
> static apr_status_t modperl_module_config_obj_cleanup(void *data)
> {
> =A0 =A0config_obj_cleanup_t *cleanup =3D
> =A0 =A0 =A0 =A0(config_obj_cleanup_t *)data;
> =A0 =A0dTHXa(cleanup->perl);
>
> =A0 =A0MP_ASSERT_CONTEXT(aTHX);
>
> =A0 =A0modperl_svptr_table_delete(aTHX_ cleanup->table, cleanup->ptr);
>
> =A0 =A0MP_TRACE_c(MP_FUNC, "deleting ptr 0x%lx from table 0x%lx",
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 (unsigned long)cleanup->ptr,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 (unsigned long)cleanup->table);
>
> =A0 =A0return APR_SUCCESS;
> }
>
> Meanwhile, I have reverted change 1145161 in trunk.
>
> Fred, could you please roll another rc?
>
> Torsten F=F6rtsch
>
> --
> Need professional modperl support? Hire me! (http://foertsch.name)
>
> Like fantasy? http://kabatinte.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org