Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of torsten.foertsch@gmx.net
 designates 213.165.64.23 as permitted sender)
From: Torsten =?ISO-8859-1?Q?F=F6rtsch?= <torsten.foertsch@gmx.net>
To: dev@perl.apache.org
Cc: Fred Moyer <fred@redhotpenguin.com>, Steve Hay <SteveHay@planit.com>
Subject: Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1
Date: Fri, 10 Feb 2012 19:30:42 +0100
Message-ID: <9496324.XXJrp84IX2@opi.home>
User-Agent: KMail/4.7.2 (Linux/3.1.9-1.4-vanilla; KDE/4.7.2; x86_64; ; )
In-Reply-To: <4835408.ofL0EQSRla@opi.home>
References: 
 <CAHrynWC47oKNFP-b514ELo4pLOMS0bUPJ+EOL7jCrS1dvfp60Q@mail.gmail.com>
 <5131378.OE8j7cmkIZ@opi.home> <4835408.ofL0EQSRla@opi.home>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Tuesday, 07 February 2012 18:01:50 Torsten F=F6rtsch wrote:
> What to do now? I'd suggest to revert change 1145161 and get 2.0.6 ou=
t
> (perhaps with Steve's latest patch). Steve, do you use perl 5.14? If
> yes, can you try if you see the "panic: free from wrong pool" also wi=
th
> 5.12?
On Wednesday, 08 February 2012 09:33:52 Steve Hay wrote:
> I think my patch is good, but clearly isn't the whole story.

By now I think Steve's patch should not be necessary. I believe the wro=
ng=20
context is a result of using the wrong interpreter pool in the director=
y=20
merge.

I think it is a bug if at that point aTHX differs from PERL_GET_CONTEXT=
. So, I=20
added the following macros to the threading branch.

#ifdef MP_DEBUG
#  define MP_ASSERT(exp) ap_assert(exp)
#else
#  define MP_ASSERT(exp) ((void)0)
#endif

#ifdef USE_ITHREADS
#  define MP_ASSERT_CONTEXT(perl) MP_ASSERT((perl) =3D=3D PERL_GET_CONT=
EXT)
#else
#  define MP_ASSERT_CONTEXT(perl) ((void)0)
#endif

The latter macro is then used in modperl_module_config_obj_cleanup() to=
 check=20
the context:

static apr_status_t modperl_module_config_obj_cleanup(void *data)
{
    config_obj_cleanup_t *cleanup =3D
        (config_obj_cleanup_t *)data;
    dTHXa(cleanup->perl);

    MP_ASSERT_CONTEXT(aTHX);

    modperl_svptr_table_delete(aTHX_ cleanup->table, cleanup->ptr);

    MP_TRACE_c(MP_FUNC, "deleting ptr 0x%lx from table 0x%lx",
               (unsigned long)cleanup->ptr,
               (unsigned long)cleanup->table);

    return APR_SUCCESS;
}

Meanwhile, I have reverted change 1145161 in trunk.

Fred, could you please roll another rc?

Torsten F=F6rtsch

--=20
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org