perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Moyer <f...@redhotpenguin.com>
Subject Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c
Date Sat, 13 Aug 2011 05:24:29 GMT
On Sun, Jul 31, 2011 at 10:57 PM, Salvador Ortiz Garcia <sog@msg.com.mx> wrote:
>> Do you have a link to that email?  I looked on gossamer-threads but
>> didn't have enough time to track it down.
>
> Sure: http://www.gossamer-threads.com/lists/modperl/modperl/103205#103205
>
> BTW, after a new review I think that Wade's patch isn't complete:
> "Symbol.xs" do not include "mod_perl.h" so it needs its own macro
> definition.
>
> Can you take a look, please?

Thanks, I added the macro to Symbol.xs, and changed the argument
layout in mod_perl.h to match your patch.  The order of variables made
more intuitive sense.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message