perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Salvador Ortiz Garcia <...@msg.com.mx>
Subject Re: Fwd: svn commit: r1151596 - in /perl/modperl/branches/1.x: Changes Symbol/Symbol.xs src/modules/perl/Constants.xs src/modules/perl/Log.xs src/modules/perl/mod_perl.c src/modules/perl/mod_perl.h src/modules/perl/perl_config.c
Date Mon, 01 Aug 2011 05:57:05 GMT
On 07/31/2011 12:28 AM, Fred Moyer wrote:
> On Thu, Jul 28, 2011 at 1:42 AM, Salvador Ortiz Garcia<sog@msg.com.mx>  wrote:
>> The commited patch has two typos:
> Thanks again for the review, fixes applied r1152547.  All tests
> successful with 5.14.1.
>
Thanks to you.
>> Btw, Wade's patch, posted on Jul 11, is very similar to mine, posted on Jun
>> 28.
> Do you have a link to that email?  I looked on gossamer-threads but
> didn't have enough time to track it down.
Sure: http://www.gossamer-threads.com/lists/modperl/modperl/103205#103205

BTW, after a new review I think that Wade's patch isn't complete:
"Symbol.xs" do not include "mod_perl.h" so it needs its own macro 
definition.

Can you take a look, please?

Thanks.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message