perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Förtsch <torsten.foert...@gmx.net>
Subject Re: Apache2::RequestUtil weirdness
Date Tue, 19 Apr 2011 07:49:18 GMT
On Tuesday, April 19, 2011 08:35:25 Fred Moyer wrote:
> Can you post test results for the case where the lines are removed?

All tests successful.
Files=248, Tests=2692, 135 wallclock secs ( 1.51 usr  0.55 sys + 103.27 cusr 
11.39 csys = 116.72 CPU)
Result: PASS

And this is the suggested change:

Index: t/protocol/TestProtocol/pseudo_http.pm
===================================================================
--- t/protocol/TestProtocol/pseudo_http.pm      (revision 1089430)
+++ t/protocol/TestProtocol/pseudo_http.pm      (working copy)
@@ -165,6 +165,8 @@
           AuthUserFile @ServerRoot@/htdocs/protocols/basic-auth
       </IfModule>
 
+      AuthName TestProtocol::pseudo_http
+      AuthType Basic
       Require user stas
       Satisfy any
 
Index: xs/Apache2/RequestUtil/Apache2__RequestUtil.h
===================================================================
--- xs/Apache2/RequestUtil/Apache2__RequestUtil.h       (revision 1089430)
+++ xs/Apache2/RequestUtil/Apache2__RequestUtil.h       (working copy)
@@ -154,12 +154,6 @@
                                                     &core_module);
 
         if (strEQ(entry->d, location)) {
-            if (!entry->ap_auth_type) {
-                entry->ap_auth_type = "Basic";
-            }
-            if (!entry->ap_auth_name) {
-                entry->ap_auth_name = apr_pstrdup(p, location);
-            }
             r->per_dir_config =
                 ap_merge_per_dir_configs(p, s->lookup_defaults, sec[i]);
             return 1;


Anyway, the httpd 2.4 port requires a lot of changes in the aaa phases. All 
related stuff has been outsourced from the core module. So, I suggest the 
change not only because I think AuthType and AuthName must not be hard coded 
here but also because I am not sure yet how to support that with httpd 2.4.

Torsten Förtsch

-- 
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message