perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Förtsch <torsten.foert...@gmx.net>
Subject PERL_SET_CONTEXT
Date Thu, 03 Mar 2011 19:29:43 GMT
Hi,

modperl_config.h contains this macro:

#ifdef USE_ITHREADS
#   define MP_dTHX                                              \
    modperl_interp_t *interp =                                  \
        modperl_interp_select(r, r->connection, r->server);     \
    dTHXa(interp->perl);
#else
#   define MP_dTHX dNOOP
#endif

It is supposed to switch to a free perl interpreter. But don't we need also to 
set the interpreter in the current thread? In other words shouldn't it read 
rather

#ifdef USE_ITHREADS
#   define MP_dTHX                                              \
    modperl_interp_t *interp =                                  \
        modperl_interp_select(r, r->connection, r->server);     \
    dTHXa(interp->perl);                                        \
    PERL_SET_CONTEXT(aTHX)
#else
#   define MP_dTHX dNOOP
#endif

Thoughts?

Torsten Förtsch

-- 
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message