perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Moyer <f...@redhotpenguin.com>
Subject Re: [mp2] Apache2::SizeLimit should be using $s->rss, not $s->size for Linux::Smaps
Date Thu, 10 Feb 2011 04:18:22 GMT
On Wed, Feb 9, 2011 at 5:42 PM, Fred Moyer <fred@redhotpenguin.com> wrote:
> On Wed, Feb 9, 2011 at 5:24 PM, Max Kanat-Alexander <mkanat@bugzilla.org> wrote:
>> On 02/02/2010 02:19 PM, Fred Moyer wrote:
>>> Can you submit these patches inline?
>>
>>        Here is the patch inline:
>
> Thanks - expect 0.96 in the next day.

Actually, I haven't had enough time to review this - thought it was a
different issue.

Can you add a test case?  I think Torsten had some concerns about the
change, and I don't have enough tuits right now to spend an hour or
two making sure this is right.

>
>>
>> Index: lib/Apache/SizeLimit/Core.pm
>> ===================================================================
>> --- lib/Apache/SizeLimit/Core.pm        (revision 905815)
>> +++ lib/Apache/SizeLimit/Core.pm        (working copy)
>> @@ -175,7 +175,7 @@
>>     return $class->_linux_size_check() unless $USE_SMAPS;
>>
>>     my $s = Linux::Smaps->new($$)->all;
>> -    return ($s->size, $s->shared_clean + $s->shared_dirty);
>> +    return ($s->rss, $s->shared_clean + $s->shared_dirty);
>>  }
>>
>>  sub _linux_size_check {
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message