Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of torsten.foertsch@gmx.net
 designates 213.165.64.23 as permitted sender)
From: Torsten =?iso-8859-1?q?F=F6rtsch?= <torsten.foertsch@gmx.net>
To: dev@perl.apache.org
Subject: Re: Trunk: A::R and A::SL test failures
Date: Sat, 14 Aug 2010 21:06:24 +0200
User-Agent: KMail/1.13.5 (Linux/2.6.34-12-desktop; KDE/4.4.4; x86_64; ; )
Cc: Fred Moyer <fred@redhotpenguin.com>
References: <201008132055.51020.torsten.foertsch@gmx.net>
 <AANLkTinEirST88hB+zM2abad2=N1Ghepj6BvvHMggubw@mail.gmail.com>
In-Reply-To: <AANLkTinEirST88hB+zM2abad2=N1Ghepj6BvvHMggubw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201008142106.25102.torsten.foertsch@gmx.net>

On Saturday, August 14, 2010 05:23:09 Fred Moyer wrote:
> 2010/8/13 Torsten F=F6rtsch <torsten.foertsch@gmx.net>:
> > I am trying to compile/test trunk with a freshly compiled perl and
> > apache. There hasn't been installed a modperl nor A::T/A::R/A::SL for
> > this perl.
>=20
> Hmm, nice catch.  Can we do something similar to Apache::Test for this
> where it uses a bundled test package?

This is nasty!

TestHarness checks for the existence of "A-T/lib" and "lib" already to find=
=20
Apache::Test when it runs from the perl-framework (the apache test suite) a=
nd=20
when it wants to test A::T itself.

This patch adds one more special case. But it is the natural way to solve t=
he=20
"Can't locate Apache/Test.pm" issue for A::R/t/all.t.

One thing it didn't know yet is that all.t is a special name. This test is =
run=20
twice. Only the first time it choked about @INC.

On the other hand, since it chokes only when it is called from
Apache::TestHarness->prune and since it is special either all.t could modif=
y=20
its @INC or prune() could be made smarter.

Please comment!

=46urther, I have noticed a small inconsistency in=20
http://perl.apache.org/docs/general/testing/testing.html. It says that all.=
t=20
is special. But the code checks for /\Wall\.t$/. So, 0-all.t and similar ar=
e=20
also special. Is that a bug in the code or in testing.html?

Index: lib/Apache/TestHarness.pm
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- lib/Apache/TestHarness.pm   (revision 985316)
+++ lib/Apache/TestHarness.pm   (working copy)
@@ -74,6 +74,7 @@
         my $top_dir =3D Apache::Test::vars('top_dir');
=20
         foreach my $lib (catfile($top_dir, qw(Apache-Test lib)),
+                         catfile($top_dir, qw(.. Apache-Test lib)),
                          catfile($top_dir, 'lib')) {
=20
             if (-d $lib) {
Index: lib/Apache/TestConfig.pm
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- lib/Apache/TestConfig.pm    (revision 985316)
+++ lib/Apache/TestConfig.pm    (working copy)
@@ -35,7 +35,8 @@
     require Apache2::Build && Apache2::Build::IS_MOD_PERL_BUILD();
=20
 use constant IS_APACHE_TEST_BUILD =3D>
=2D    grep { -e "$_/lib/Apache/TestConfig.pm" } qw(Apache-Test . ..);
+    grep { -e "$_/lib/Apache/TestConfig.pm" }
+         qw(Apache-Test . .. ../Apache-Test);
=20
 use constant CUSTOM_CONFIG_FILE =3D> 'Apache/TestConfigData.pm';


Torsten F=F6rtsch

=2D-=20
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org