perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Moyer <f...@redhotpenguin.com>
Subject Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Date Sun, 22 Aug 2010 20:35:16 GMT
2010/8/22 Torsten Förtsch <torsten.foertsch@gmx.net>:
> On Sunday, August 22, 2010 21:46:58 Fred Moyer wrote:
>> 2010/8/22 Torsten Förtsch <torsten.foertsch@gmx.net>:
>> > On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
>> >> I put out a release candidate for Apache-Test 1.33 yesterday.  Did you
>> >> see the email come through?  An archive copy of it is located here:
>> >>
>> >> http://www.gossamer-threads.com/lists/modperl/dev/101934
>>
>> ...
>>
>> > However, I think that change should go to the release. It fixes a bug
>> > that can cause errors that are difficult to trace.
>>
>> Having encountered these errors before, I know they exist.  However,
>> can you update the docs to provide some example usage?  When I set
>> this variable, this happens on make test:
>>
>> You specified APACHE_TEST_NO_STICKY_PREFERENCES=1 in which case you
>> must explicitly specify -httpd and/or -apxs options
>>
>> And then make test -httpd=.... isn't something that will work.
>> Neither will it as a makefile arg.  Can you add example usage for
>> those like me who know the hooks exist, but can't ever remember the
>> syntax?
>>
>>
>> phred@pooky ~/dev/svn/modperl/Apache-Test $ perl Makefile.PL
>> -httpd=/Users/phred/dev/sl/httpd/sbin/httpd
>> generating script t/TEST
>> generating script ./t/cgi-bin/cookies.pl
>> generating script ./t/cgi-bin/next_available_port.pl
>> '-HTTPD' is not a known MakeMaker parameter name.
>
> I believe this one you know:
>
> http://search.cpan.org/~phred/Apache-
> Test-1.32/lib/Apache/TestRun.pm#Persistent_Custom_Configuration
>
> Here is what I do in my SPEC files:
>
> %build
> export APACHE_TEST_NO_STICKY_PREFERENCES=1
> %perl Makefile.PL
> make %{?jobs:-j%jobs} &&
> t/TEST -apxs %{apxs} -httpd_conf %{sysconfdir}/original/httpd-modperl.conf
>
> I also think it would make more sense to pass these things as Makefile.PL
> parameters. Though, you can set them as environment variables.

Duh - forgot about being able to set those as environment variables.
So we have a mix of Makefile.PL parameters and environment variables
controlling behavior.  I've got my head in this code as much as anyone
else, and I have no idea of what all of those are.  MOD_PERL_1_BUILD,
and friends are all over the place.

Can you add the environment variable options to the docs you added?
If an unaware user runs 'make test' with this variable enabled, they
basically hit a dead end in terms of usage if they don't remember
APACHE_TEST_APXS et. al. (remember that the user is not reminded of
that variable unless they successfully execute perl Makefile.PL, since
it dies before that reminder is shown).

I don't mind rolling another RC, but if features are going in (since
there is bug report for this issue I'm calling it a feature), then
they should be really well documented.  Apache-Test's biggest drawback
is lots and lots of hidden hooks and variables that very few people
know how to use, and are not straightforward to find in the docs.

> I have set in my environment APACHE_TEST_NO_STICKY_PREFERENCES=1 and
> APACHE_TEST_APXS=/path/to/apxs. That is enough to make "make test" work.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message