Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: local policy)
MIME-Version: 1.0
In-Reply-To: <20100623190613.39F88238888F@eris.apache.org>
References: <20100623190613.39F88238888F@eris.apache.org>
Date: Tue, 29 Jun 2010 22:01:59 -0700
Message-ID: <AANLkTimNyFHO34fLLmBa4oUfKnXSykxQm9_4kukrAEFd@mail.gmail.com>
Subject: Re: svn commit: r957309 - in /perl/modperl/trunk: Changes Makefile.PL
From: Fred Moyer <fred@redhotpenguin.com>
To: dev@perl.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

As a follow up to this commit, I discussed additional steps needed on
IRC with Gozer.  He asked me to check make dist to be sure that it
generated the correct MANIFEST which included the bundled
Apache-SizeLimit and Apache-Reload modules.  I just went over that
issue and the distribution includes the desired pure perl modules.
make rpm appears to include those modules also.

However, those included modules are using -dev versions (A:T 1.33-dev
for example) :(

If we want the distro to include released versions, that will mean
that those bundled modules will need to be svn updated to the stable
tags before building the bundled distribution.  That or update the
release procedures for the bundled modules and do dev on branches - I
like that solution less.

Thoughts?

On Wed, Jun 23, 2010 at 12:06 PM,  <phred@apache.org> wrote:
> Author: phred
> Date: Wed Jun 23 19:06:12 2010
> New Revision: 957309
>
> URL: http://svn.apache.org/viewvc?rev=3D957309&view=3Drev
> Log:
> Run tests on bundled pure perl modules.
>
> Written by: Phred, Gozer
> Reviewed by: Adam Prime, Gozer, Phred, Pgollucci
> Tested by: Phred
>
> Modified:
> =A0 =A0perl/modperl/trunk/Changes
> =A0 =A0perl/modperl/trunk/Makefile.PL
>
> Modified: perl/modperl/trunk/Changes
> URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?rev=3D957309=
&r1=3D957308&r2=3D957309&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- perl/modperl/trunk/Changes (original)
> +++ perl/modperl/trunk/Changes Wed Jun 23 19:06:12 2010
> @@ -12,6 +12,8 @@ Also refer to the Apache::Test changes l
>
> =A0=3Ditem 2.0.5-dev
>
> +Run tests on bundled pure perl Apache::* modules [Gozer, Phred]
> +
> =A0Implement a mini-preprocess language for map-files in xs/maps.
> =A0[Torsten Foertsch]
>
>
> Modified: perl/modperl/trunk/Makefile.PL
> URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Makefile.PL?rev=3D95=
7309&r1=3D957308&r2=3D957309&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- perl/modperl/trunk/Makefile.PL (original)
> +++ perl/modperl/trunk/Makefile.PL Wed Jun 23 19:06:12 2010
> @@ -785,7 +785,16 @@ run_tests : test_clean
> =A0 =A0 =A0 =A0$(PASSENV) \
> =A0 =A0 =A0 =A0$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
> =A0 =A0 =A0 =A0t/TEST -bugreport -verbose=3D$(TEST_VERBOSE) $(TEST_FILES)
> - =A0 =A0 =A0 cd ModPerl-Registry && $(MAKE) test
> + =A0 =A0 =A0 $(MAKE) -k run_subtests
> +
> +run_subtests ::
> + =A0 =A0 =A0 $(MAKE) -C ModPerl-Registry test
> +
> +run_subtests ::
> + =A0 =A0 =A0 $(MAKE) -C Apache-Reload test
> +
> +run_subtests ::
> + =A0 =A0 =A0 $(MAKE) -C Apache-SizeLimit test
>
> =A0test :: pure_all run_tests test_clean
> =A0EOF
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org