perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: [patch] make test runs test on included modules
Date Tue, 15 Jun 2010 02:47:33 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/14/10 19:46, Philippe M. Chiasson wrote:
> On 10-06-14 15:16 , Fred Moyer wrote:
>> I put this patch together as part of the todo list for 2.0.5.  Gozer,
>> is this what we are looking for?
>>
>> Index: Makefile.PL
>> ===================================================================
>> --- Makefile.PL (revision 953555)
>> +++ Makefile.PL (working copy)
>> @@ -786,6 +786,8 @@
>>         $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
>>         t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES)
>>         cd ModPerl-Registry && $(MAKE) test
>> +       cd Apache-Reload && $(MAKE) test
>> +       cd Apache-SizeLimit && $(MAKE) test
> 
> Yeah, except the problem of failures and return codes, IMO. You want to
> run all 3 of these, no matter what. However, you want to return success
> if and only if they all worked and failure if *either* failed.
> 
This is where I dropped it at last.  I never made it through.  There was
some complexity that killed me.  I forget what that was in 2k6 though.


- -- 
- ------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iD8DBQFMFunEdbiP+9ubjBwRAl9/AJ4+TVDhmNsH6uvzggRgKm/k8TvH8QCfXdyU
OofkwsTeWMWSfpKN8KwwDd8=
=HbRa
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message