perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <randy.ko...@gmail.com>
Subject Re: simplify mod_perl.c a bit
Date Fri, 02 Apr 2010 18:22:10 GMT
+1.

-- 
best regards,
Randy

On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote:

> +1
> 
> On 03/31/10 15:07, Torsten Förtsch wrote:
>> Hi,
>> 
>> the patch below simplifies mod_perl.c a bit.
>> 
>> Instead of
>> 
>> modperl_response_handler_run(r, finish) {
>>   do something
>>   if( finish ) {
>>     modperl_response_finish()
>>   }
>> }
>> 
>> and calling that function in one place as
>> 
>> modperl_response_handler_run(r, TRUE)
>> 
>> and in the second place as
>> 
>> modperl_response_handler_run(r, TRUE)
>> do something
>> modperl_response_finish()
>> 
>> it now looks like
>> 
>> modperl_response_handler_run(r) {
>>   do something
>> }
>> 
>> 1st usage:
>> modperl_response_handler_run(r)
>> modperl_response_finish()
>> 
>> 2nd usage:
>> modperl_response_handler_run(r)
>> do something
>> modperl_response_finish()
>> 
>> Torsten Förtsch


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message