perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [Patch] Apache2::Reload
Date Sat, 29 Aug 2009 01:35:50 GMT
On 28/08/09 08:35 , Ryan Gies wrote:
> This patch for Apache2::Reload does two things:
> 
>   A) ignores require-hooks which exist in %INC. (fix)

That's a very good fix indeed, and should be fixed by itself, yes.

>   B) reloads by file, not module name (fix?)

Good feature, good patch. I've got only one simple style nit with it.

Instead of:

+    foreach my $kvpair (@changed) {
+        my $name = $ReloadByModuleName ? $kvpair->[0] : $kvpair->[1];
+        require $name;


I just find $kvpair and $kvpair->[0] somewhat hard to read, could you
simply change it to something like:

+    foreach my $change (@changed) {
+        my $module = $change->[0];
+        my $file = $change->[1];
+        my $name = $ReloadByModuleName ? $module: $file;
+        require $name;

Apart from that, it's a great patch!

Could you resend 2 patches (splitting A) and B) in different ones) with
that small concern adressed ?

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Mime
View raw message