perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: svn commit: r807116 - in /perl/modperl/trunk: Changes lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm
Date Mon, 24 Aug 2009 17:35:17 GMT
On 24/08/09 04:29 , torsten@apache.org wrote:
> Author: torsten
> Date: Mon Aug 24 08:29:43 2009
> New Revision: 807116
> 
> URL: http://svn.apache.org/viewvc?rev=807116&view=rev
> Log:
> Fix a typo in ModPerl::BuildMM. Fix a compile time issue by introducing
> lexically scoped loop variables in ModPerl::MM::WriteMakefile().

Great, thanks for the fixes!

> Modified:
>     perl/modperl/trunk/Changes
>     perl/modperl/trunk/lib/Apache2/Build.pm
>     perl/modperl/trunk/lib/ModPerl/BuildMM.pm
>     perl/modperl/trunk/lib/ModPerl/MM.pm
> 
> Modified: perl/modperl/trunk/Changes
> URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?rev=807116&r1=807115&r2=807116&view=diff
> ==============================================================================
> --- perl/modperl/trunk/Changes (original)
> +++ perl/modperl/trunk/Changes Mon Aug 24 08:29:43 2009
> @@ -12,6 +12,9 @@
>  
>  =item 2.0.5-dev
>  
> +Fix a typo in ModPerl::BuildMM and introduce lexically scoped loop
> +variables in ModPerl::MM::WriteMakefile(). [Torsten Foertsch]

I'd reword that to be a bit more descriptive to the folks likely to be reading
this to determine if they should update. Something like:

"MODPERL_INC= now correctly supported as an argument to Makefile.PL"

The lexically scoped loop variables should have no impact at all to a potential
upgrader, so it doesn't really need to be mentionned.

>  Fix an XSS issue in Apache2::Status reported by Richard J. Brain
>  <richard@procheckup.com>. [Torsten Foertsch]
>  
> 
> Modified: perl/modperl/trunk/lib/Apache2/Build.pm
> URL: http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.pm?rev=807116&r1=807115&r2=807116&view=diff
> ==============================================================================
> --- perl/modperl/trunk/lib/Apache2/Build.pm (original)
> +++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43 2009
> @@ -2068,6 +2068,7 @@
>  }
>  
>  sub inc {
> +    local $_;
>      my @includes = map { "-I$_" } @{ shift->includes };
>      "@includes";
>  }

With the rest of the changes in this patch, is this particular change still
necessary?

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Mime
View raw message