perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <torsten.foert...@gmx.net>
Subject Re: svn commit: r807116 - in /perl/modperl/trunk: Changes lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm
Date Mon, 24 Aug 2009 18:31:51 GMT
On Mon 24 Aug 2009, Philippe M. Chiasson wrote:
> > Modified: perl/modperl/trunk/lib/Apache2/Build.pm
> > URL:
> > http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.p
> >m?rev=807116&r1=807115&r2=807116&view=diff
> > ===================================================================
> >=========== --- perl/modperl/trunk/lib/Apache2/Build.pm (original)
> > +++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43
> > 2009 @@ -2068,6 +2068,7 @@
> >  }
> >  
> >  sub inc {
> > +    local $_;
> >      my @includes = map { "-I$_" } @{ shift->includes };
> >      "@includes";
> >  }
>
> With the rest of the changes in this patch, is this particular change
> still necessary?

Not really, but it's a safety measure. The "for ()" idiom is used in 
many places. And I know these pieces of code that had bitten me now are 
years old. Don't know why it happened now. So, I'd like to have it 
there.

Torsten

-- 
Need professional mod_perl support?
Just hire me: torsten.foertsch@gmx.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message