Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 48560 invoked from network); 6 Jun 2009 02:57:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Jun 2009 02:57:59 -0000 Received: (qmail 5748 invoked by uid 500); 6 Jun 2009 02:58:10 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 5683 invoked by uid 500); 6 Jun 2009 02:58:10 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 5671 invoked by uid 99); 6 Jun 2009 02:58:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jun 2009 02:58:10 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [207.5.72.95] (HELO EXHUB015-3.exch015.msoutlookonline.net) (207.5.72.95) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Jun 2009 02:58:01 +0000 Received: from [192.168.1.3] (72.83.160.7) by smtpx15.msoutlookonline.net (207.5.72.103) with Microsoft SMTP Server (TLS) id 8.1.358.0; Fri, 5 Jun 2009 19:57:40 -0700 Message-ID: <4A29DB23.9070408@p6m7g8.com> Date: Fri, 5 Jun 2009 22:57:39 -0400 From: "Philip M. Gollucci" Organization: P6 Web Applications User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: dev@perl.apache.org CC: modperl-cvs@perl.apache.org Subject: Re: svn commit: r781917 - in /perl/modperl/branches/1.x: Changes src/modules/perl/mod_perl.c References: <20090605055718.2C8A82388849@eris.apache.org> <4A29D13F.60504@apache.org> In-Reply-To: <4A29D13F.60504@apache.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org > Small nit, shouldn't it be : > char **temp_args = argv; > > Also, feels like that bit of code needs a warning/comment to explain why > it's there, otherwise, it's tempting to optimize/clean it away. mumble /me hates 1.3 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org