perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Moyer <f...@redhotpenguin.com>
Subject Re: [patch] http://rt.cpan.org/Public/Bug/Display.html?id=21554
Date Wed, 22 Apr 2009 02:16:11 GMT
Any other thoughts on this from the dev list (Adam commented on this
thread already)?  Here's a copy of the diff again.  This was marked as
a critical bug for Apache::Test, but I moved it to wishlist (since it
is an enhancement).

There are currently 4 open RT tickets for Apache::Test, this is one of
them.  The other three probably need to cook longer before the
version.pm issues are ironed out.  This is down from 9 open tickets a
week ago, I've managed to resolve a lot of them.

Index: lib/Apache/TestRunPerl.pm
===================================================================
--- lib/Apache/TestRunPerl.pm   (revision 766433)
+++ lib/Apache/TestRunPerl.pm   (working copy)
@@ -73,6 +73,22 @@
        Apache::TestRun::exit_perl(0);
    }

+    if ($rev == 2) {
+        # load apreq2 if it is present
+        # do things a bit differently that find_and_load_module()
+        # because apreq2 can't be loaded that way (the 2 causes a problem)
+        my $name = 'mod_apreq2.so';
+        my $mod_path = $test_config->find_apache_module($name) or return;
+
+        # don't match the 2 here
+        my ($sym) = $name =~ m/mod_(\w+)2\./;
+
+        if ($mod_path && -e $mod_path) {
+            $test_config->preamble(IfModule => "!mod_$sym.c",
+                        qq{LoadModule ${sym}_module "$mod_path"\n});
+        }
+    }
+
    $test_config->preamble_register(qw(configure_libmodperl
                                       configure_env));

On Mon, Apr 20, 2009 at 10:15 AM, Adam Prime <adam.prime@utoronto.ca> wrote:
> Fred Moyer wrote:
>>>
>>> Fred Moyer wrote:
>>
>>
>> Configuring Apache::Test is not easy (drawing from my own personal
>> experiences and comments on RT tickets, etc), so I think that making
>> some changes like this so that it 'just works' in more situations is a
>> prudent move.  We don't want A::T to become bloated, but I think we
>> are very much on the lean side, and could use some changes to make it
>> easier to use.  I think people recognize the cool factor of
>> Apache::Test, but have a hard time figuring out all the nuances.
>
> Agreed.
>
> Adam
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message