perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [PATCH] prototypes/constant redefinition warnings from ModPerl::Util
Date Wed, 12 Nov 2008 14:40:51 GMT


Casey West wrote:
> On Sat, Nov 8, 2008 at 8:55 PM, Geoffrey Young
> <geoff@modperlcookbook.org> wrote:
>> Geoffrey Young wrote:
>>> -            undef &$fullname;
>>> +            delete ${$fullname}{CODE};
>>>
>>> I swear there is some p5p history here that treats that slot differently
>>> when it's undef versus exists.  IIRC an early 5.8.0 iteration broke
>>> mod_perl because of exactly this (or, if you prefer, mod_perl exposed a
>>> feature of perl that we prefer to remain ;)
> [...]
>> http://marc.info/?l=perl5-porters&m=106752791011060&w=2
> 
> Geoff,
> 
> Are you sure the referenced issue is the same one that line is trying
> to handle? It appears that the undef vs delete issue is related to
> loading Perl modules from disk and managing the %INC cache. The delete
> in my patch is about tearing down the stash before the package's
> reference is eliminated from %INC. I'm worried we're talking about two
> different things. Do you see what I mean?

we probably are talking about two different things.  in truth, it just
looked familiar - I wasn't entirely sure about the context, which is why
I went hunting for the thread :)

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message