perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: [PATCH] Apache2::RequestIO::read bugfix + enhancements
Date Fri, 18 Jul 2008 02:47:03 GMT
Torsten Foertsch wrote:
> Please review.
+        /* use the same error message as perl core's read() */
+        Perl_croak(aTHX_ "Negative length");
It possible someone is regexing $@ against the previous string. Do you 
really need to change the message ?


+    /* modperl_request_read can return only >=0. So it's save to do 
this. */
+    /* if total==0 we need to set the buffer length in case it is larger */


s/save/safe/


By any chance have you tried mod_apreq2 perl glue on top of this patch ?

+1


-- 
------------------------------------------------------------------------
Philip M. Gollucci (philip@ridecharge.com)
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com / http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message