perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <torsten.foert...@gmx.net>
Subject Re: $r->location bug
Date Fri, 22 Feb 2008 10:38:37 GMT
On Fri 22 Feb 2008, Philippe M. Chiasson wrote:
> -    parms.path = path;
> +    parms.path = apr_pstrdup(p, path);

Yes, Philippe, you are right.

In current modperl there are 3 ways to get to modperl_config_insert():

- $r->add_config via modperl_config_insert_request
- $s->add_config via modperl_config_insert_server
- $parms->add_config via modperl_config_insert_parms

Since $parms->path is read-only and modperl_config_insert_server passes a NULL 
as path there is only one way to have a custom path passed to 
modperl_config_insert, modperl_config_insert_request. So patching 
$r->add_config only would be sufficient, as well.

Nevertheless, fixing it in modperl_config_insert is probably the best way 
regarding future changes.

Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message