perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <torsten.foert...@gmx.net>
Subject Re: [mp2] mod_perl closes apache's stdin and/or stdout
Date Tue, 18 Dec 2007 07:56:22 GMT
On Tue 18 Dec 2007, Philippe M. Chiasson wrote:
> >> Dmitry's patch from  Sep 25, 2007
> >> http://www.gossamer-threads.com/lists/modperl/modperl/94912 has still
> >> not been applied to SVN. May I humbly ask that this patch is applied?
> >
> > I remember that Toersten and I put together a unit test for this but I
> > don't think there was any change in behavior with this patch, so I'm not
> > sure if anyone was able to demonstrate that it changed the behavior.
>
> It certainly breaks t/modperl/io_nested_with_closed_stds
> [error] [client 127.0.0.1] Filehandle STDOUT reopened as STDIN only for
> input at t/response/TestModperl/io_nested_with_closed_stds.pm line 49.\n
>
> > If you have the tuits and could track down that unit test, show that it
> > exercises the problem in question, we probably wouldn't need much else
> > to apply this patch.  I'd try to do this but am overextended on my tuits
> > right now.
>
> Yup, without a test case that correctly demonstrates the bug, and a patch
> that doesn't break existing tests, not very likely to get applied.

This patch is something I wanted to investigate more thoroughly but as ever 
there is no time left for interesting problems.

I think Dmitrys argument about file descriptors being a shared/global resource 
and hence must not be closed is very strong. But on the other hand existing 
tests must not be broken. (or otherwise clearly explained why the test is 
buggy) And of course a test that demonstate the bug is necessary.

Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message