perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <torsten.foert...@gmx.net>
Subject Re: Please help adding ModPerl::Interpreter
Date Wed, 14 Nov 2007 09:19:52 GMT
Hi Philippe,

I am glad to see that all my patches are now applied to the threading branch. 
The tweaks you have mentioned are only related to tab-based indentation, 
right?

I have noticed that you have also deleted some trailing newlines on MP_TRACEs. 
Most MP_TRACE_x invocations have trailing newlines. For me they are rather 
disturbing but I thought they were there on purpose. So, what is the right
way to call MP_TRACE_x, with or without a trailing newline?

How about these 2 questions?

On Thu 25 Oct 2007, Torsten Foertsch wrote:
> On Thursday 25 October 2007, Philippe M. Chiasson wrote:
> > undef $r->pnotes
>
> I have never implemented an lvalue function in XS. But is that possible?
> AFAIK an lvalue function is called without the new value as parameter. So
> how can I distinguish "undef $r->pnotes" from "$r->pnotes->{key}"

> On Thursday 25 October 2007, Philippe M. Chiasson wrote:
> > We globally use 4 spece indents, _not_ the \t (tab) character.
>
[...]
> Would you mind if I append an appropriate emacs postscript to the files? So, 
> a normal emacs user would avoid these errors.
>
> Something like this to C-files:
>
> /*
>  * Local Variables:
>  * c-basic-offset: 4
>  * indent-tabs-mode: nil
>  * End:
>  */
>
> and this to Perl-files:
>
> # Local Variables: #
> # mode: cperl #
> # cperl-indent-level: 4 #
> # indent-tabs-mode: nil #
> # End: #

Can I take it as a "not at all" that you have left these comments in the code?

Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message