Mailing-List: contact dev-help@perl.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of torsten.foertsch@gmx.net
 designates 213.165.64.20 as permitted sender)
From: Torsten Foertsch <torsten.foertsch@gmx.net>
To: dev@perl.apache.org
Subject: Re: possible pnotes refcounting bug ?
Date: Thu, 11 Oct 2007 15:50:59 +0200
User-Agent: KMail/1.9.5
References: <200710111518.18560.torsten.foertsch@gmx.net>
In-Reply-To: <200710111518.18560.torsten.foertsch@gmx.net>
MIME-Version: 1.0
Content-Type: multipart/signed;
  boundary="nextPart2587405.MqSH3xWCms";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200710111551.03735.torsten.foertsch@gmx.net>

--nextPart2587405.MqSH3xWCms
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Thursday 11 October 2007 15:18, Torsten Foertsch wrote:
>     if (key) {
>         STRLEN len;
>         char *k = SvPV(key, len);
>
>         if (val) {
>             retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
>         }
>         else if (hv_exists(*pnotes, k, len)) {
>             retval = *hv_fetch(*pnotes, k, len, FALSE);
>         }
>     }
>     else {
>         retval = newRV_inc((SV *)*pnotes);
>     }
>
>     return retval ? SvREFCNT_inc(retval) : &PL_sv_undef;
>
> I am wondering whether the REFCNT is always right. *pnotes is a HV. If the
> function is called without a key argument the else branch newRV_inc
> increments the REFCNT of the HV, right? Then the return statement in the
> last line increments it again? Am I wrong?

I think it should rather read:

    if (key) {
        STRLEN len;
        char *k = SvPV(key, len);

        if (val) {
            retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
        }
        else if (hv_exists(*pnotes, k, len)) {
            retval = *hv_fetch(*pnotes, k, len, FALSE);
        }

        return retval ? SvREFCNT_inc(retval) : &PL_sv_undef;
    }
    else {
        return newRV_inc((SV *)*pnotes);
    }

Torsten

--nextPart2587405.MqSH3xWCms
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBHDipHwicyCTir8T4RAgVSAKDHzibphnxA0MhKCqZKTSdKs/RmQQCffCHe
u7J0UxfFJnWnVHTHYu5fclE=
=kPou
-----END PGP SIGNATURE-----

--nextPart2587405.MqSH3xWCms--