perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: Please help adding ModPerl::Interpreter
Date Mon, 22 Oct 2007 07:12:03 GMT
Torsten Foertsch wrote:
> On Thursday 18 October 2007, Philippe M. Chiasson wrote:
>> Any chance you can break the patch into multiple patches
> 
> This one adds the current pid to the output of modperl_trace.

Wouldn't a better all-around approach use a pid/tid combination for
threaded MPMs and fallback to pid only otherwise ?

modperl_tid_pid() does just that.

Why not clean up things like in modperl_mgv.c:

    MP_TRACE_h(MP_FUNC, "[%s] new anon handler",
        modperl_pid_tid(p));

And make modperl_trace always prefix log messages with modperl_tid_pid()?

------------------------------------------------------------------------
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Mime
View raw message