perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: Please help adding ModPerl::Interpreter
Date Wed, 17 Oct 2007 22:10:27 GMT
Torsten Foertsch wrote:
> On Saturday 13 October 2007 08:31, Philippe M. Chiasson wrote:
>> In the meantime, I've created a threading branch here:
>>
>> http://svn.apache.org/repos/asf/perl/modperl/branches/threading
>>
>> And I've applied this change (rev 584377) as the first one in hopefully
>> many more of your patches. Only change is that I added minimal tests.
>>
>> Note, this patch/test doesn't behave correctly with a non-threaded Apache.
> 
> Thanks!

No problems! While you are at it, why don't you submit a patch for:

http://perl.apache.org/about/contributors/people.html

Source here:

http//svn.apache.org/repos/asf/perl/modperl/docs/trunk/src/about/contributors/

> Please apply the enclosed x.patch to the threading branch. I have tested it 
> with perl 5.8.8 (with threads), apache 2.2.6 (worker and prefork) on linux.
> 
> I think it needs some polishing to work with a perl without ithreads.

It certainly needs some #ifdef foo to be friendly to non-ithreads perls

> The patch contains all my findings so far including the pnotes refcount 
> problem. Pnotes now lock the interpreter like pools do.

Any chance you can break the patch into multiple patches, one for each
feature/fix? Ideally with an accompanying entry in Changes ? It'll be simpler
to merge these one at a time back to the trunk/

> There is a new ${r|c}->pnotes_kill function that can be used to prematurely 
> delete pnotes.

Not sure about kill, how aobut:

->pnotes_reset() ?
->pnotes_destroy() ?

> It is useful if you want to use pnotes say from trans to fixup 
> and thus bind the interp to the request but remove that binding before 
> response. So, PerlInterpScope is advisory now.
> 
> Also new interfaces incl. tests (but without docs) for ModPerl::Interpreter, 
> ModPerl::InterpPool, ModPerl::TiPool and ModPerl::TiPoolConfig are included.

Cool, will need to have a look at all that.

> The PUTBACK flag for interpreters is removed since it is not used anymore.

Good riddance.

> The attached xx patch deletes an unused structure member from 
> modperl_interp_pool_t.

Comitted on the trunk/ as revision 585724.

------------------------------------------------------------------------
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Mime
View raw message