perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: Please help adding ModPerl::Interpreter
Date Wed, 10 Oct 2007 13:58:51 GMT


Torsten Foertsch wrote:
> Hi Geoff,
> 
> On Tuesday 09 October 2007 19:19, Geoffrey Young wrote:
>> if you're really confused, see the commits when I added Apache::MPM
>>
>>   http://marc.info/?l=apache-modperl-cvs&m=106978727408877&w=2
>>   http://marc.info/?l=apache-modperl-cvs&m=106978912311523&w=2
>>
>> the bulk of the main commit consists of the tests, but the interesting
>> changes are at the bottom.  if you just follow that pattern you should
>> be able to add the module of your choice.
> 
> I think I did it. Please have a look at the attached patch to see if it is all 
> that is needed to be done.

it looks ok.  the proof is in the tests, of course :)

> 
> The patch is a bit edited to suppress other changes in xs/. So I don't think 
> it would apply to trunk without warnings.

I don't understand that.  what other changes in xs/?  if you mean
missing directories, etc, you can use utils/getdiff.pl to generate a
reasonable diff that adds them.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message