perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <>
Subject Re: Please help adding ModPerl::Interpreter
Date Thu, 25 Oct 2007 10:35:46 GMT
On Thursday 25 October 2007, Philippe M. Chiasson wrote:
> > It was named after apr_pool_cleanup_kill(). If you don't like it then
> > what do you prefer _destroy or _reset? To me it's all the same.
> In that case, yes, pnotes_kill() probably is a bit more consistent.
> Of course, after thinking about it, the more Perl-ish thing to do would
> be to make this work:
> undef $r->pnotes

I have never implemented an lvalue function in XS. But is that possible? AFAIK 
an lvalue function is called without the new value as parameter. So how can I 
distinguish "undef $r->pnotes" from "$r->pnotes->{key}"

On Thursday 25 October 2007, Philippe M. Chiasson wrote:
> We globally use 4 spece indents, _not_ the \t (tab) character.

Are you sure? There is quite a number of files in a freshly checked out MP2 
that contain tabs and that where never touched by me:

$ grep -rl '       ' . | grep -v -e '\.svn' -e '\.\(dia\|gif\|png\|jpe\?g\)$'

For example src/modules/perl/modperl_io.c contains tabs in 

But no problem. I can make a patch for that over the weekend. Would you mind 
if I append an appropriate emacs postscript to the files? So, a normal emacs 
user would avoid these errors.

Something like this to C-files:

 * Local Variables:
 * c-basic-offset: 4
 * indent-tabs-mode: nil
 * End:

and this to Perl-files:

# Local Variables: #
# mode: cperl #
# cperl-indent-level: 4 #
# indent-tabs-mode: nil #
# End: #


View raw message