perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From f...@taperfriendlymusic.org
Subject Apache2::Reload - SameInterp refactoring
Date Mon, 06 Aug 2007 00:27:37 GMT
Hi all,

I was hacking on getting the Apache2::Reload distro independent today and
have identified a few things that seem like they are coupled to this
release.

TestCommon::SameInterp is used by t/modules/reload.t, but currently
resides in   t/lib/TestCommon.

There's a note in SameInterp which follows:

  META: consider merging those into Apache::TestRequest (or add a new
  module, e.g. Apache::TestRequestSameInterp)

Considering that I need SameInterp to run t/modules/reload.t, I think that
this new module idea is a great one.  Here are some suggested moves to
make this happen by moving it out of the modperl repo and into
Apache::Test.  It's not all working yet on my setup but I wanted to run
this by the group to get some feedback on the general direction here.

A  +   Apache-Test/t/response/TestApache2/sameinterp.pm
A  +   Apache-Test/lib/Apache/TestRequestSameInterp.pm
A      Apache-Test/t/apache2/all.t
A      Apache-Test/t/apache2/sameinterp.t
D      t/modperl/sameinterp.t
D      t/response/TestModperl/sameinterp.pm

Index: t/apr/pool_lifetime.t
===================================================================
--- t/apr/pool_lifetime.t       (revision 560637)
+++ t/apr/pool_lifetime.t       (working copy)
@@ -4,7 +4,7 @@
 use Apache::Test;
 use Apache::TestUtil;
 use Apache::TestRequest;
-use TestCommon::SameInterp;
+use Apache::TestRequestSameInterp;

 plan tests => 2, need 'HTML::HeadParser';

Index: t/modules/reload.t
===================================================================
--- t/modules/reload.t  (revision 560637)
+++ t/modules/reload.t  (working copy)
@@ -4,10 +4,9 @@
 use Apache::Test;
 use Apache::TestUtil;
 use Apache::TestRequest;
+use Apache::TestRequestSameInterp;
 use File::Spec::Functions qw(catfile);

-use TestCommon::SameInterp;
-
 plan tests => 3, need 'HTML::HeadParser';

 my $test_file = catfile Apache::Test::vars("serverroot"),
Index: t/modperl/cookie2.t
===================================================================
--- t/modperl/cookie2.t (revision 560637)
+++ t/modperl/cookie2.t (working copy)
@@ -14,7 +14,7 @@
 use Apache::Test;
 use Apache::TestUtil;
 use Apache::TestRequest;
-use TestCommon::SameInterp;
+use Apache::TestRequestSameInterp;

 plan tests => 3, need 'HTML::HeadParser';

Index: t/modperl/cookie.t
===================================================================
--- t/modperl/cookie.t  (revision 560637)
+++ t/modperl/cookie.t  (working copy)
@@ -19,9 +19,8 @@
 use Apache::Test;
 use Apache::TestUtil;
 use Apache::TestRequest;
+use Apache::TestRequestSameInterp;

-use TestCommon::SameInterp;
-
 plan tests => 3, need 'HTML::HeadParser';

 my $module   = 'TestModperl::cookie';

... probably half a dozen other modules which require this change also



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message