perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: Apache2::Reload - SameInterp refactoring
Date Tue, 07 Aug 2007 17:11:51 GMT
fred@taperfriendlymusic.org wrote:
> Hi all,
> 
> I was hacking on getting the Apache2::Reload distro independent today and
> have identified a few things that seem like they are coupled to this
> release.
> 
> TestCommon::SameInterp is used by t/modules/reload.t, but currently
> resides in   t/lib/TestCommon.
> 
> There's a note in SameInterp which follows:
> 
>   META: consider merging those into Apache::TestRequest (or add a new
>   module, e.g. Apache::TestRequestSameInterp)
> 
> Considering that I need SameInterp to run t/modules/reload.t, I think that
> this new module idea is a great one.

I agree, but not sure about the name ;-?

Apache::TestRequestPleaseUseTheSameInterpForThisRequest ...

How about breaking things down a bit more

Apache::TestRequest::SameInterp

Or something like that ?

>  Here are some suggested moves to
> make this happen by moving it out of the modperl repo and into
> Apache::Test.

A good idea IMO.

>  It's not all working yet on my setup but I wanted to run
> this by the group to get some feedback on the general direction here.
> 
> A  +   Apache-Test/t/response/TestApache2/sameinterp.pm
> A  +   Apache-Test/lib/Apache/TestRequestSameInterp.pm
> A      Apache-Test/t/apache2/all.t
> A      Apache-Test/t/apache2/sameinterp.t
> D      t/modperl/sameinterp.t
> D      t/response/TestModperl/sameinterp.pm
> 
> [...]
> 
> ... probably half a dozen other modules which require this change also

Feels like a step in the correct direction. I'd go for it.

------------------------------------------------------------------------
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Mime
View raw message