Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 84136 invoked from network); 13 Jul 2007 17:53:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Jul 2007 17:53:55 -0000 Received: (qmail 18794 invoked by uid 500); 13 Jul 2007 17:53:58 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 18616 invoked by uid 500); 13 Jul 2007 17:53:57 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 18605 invoked by uid 99); 13 Jul 2007 17:53:57 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2007 10:53:57 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [66.77.29.165] (HELO secure.exclamationlabs.net) (66.77.29.165) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2007 10:53:54 -0700 Received: from helm.modperlcookbook.net (c-69-141-1-101.hsd1.pa.comcast.net [69.141.1.101]) (authenticated (0 bits)) by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id l6DHrbw15333 for ; Fri, 13 Jul 2007 12:53:37 -0500 Message-ID: <4697BC1C.8040107@modperlcookbook.org> Date: Fri, 13 Jul 2007 13:53:32 -0400 From: Geoffrey Young User-Agent: Thunderbird 2.0.0.4 (X11/20070615) MIME-Version: 1.0 To: dev@perl.apache.org Subject: [Fwd: MP2: Patch to fix dynamic loading under OpenBSD (Was: Patches for two problems under OpenBSD)] X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org -------- Original Message -------- Subject: MP2: Patch to fix dynamic loading under OpenBSD (Was: Patches for two problems under OpenBSD) Date: Sun, 10 Jun 2007 20:38:53 +0200 From: Simon Bertrang To: modperl@perl.apache.org References: <20070609182229.GD2049@codefish> On Sat, Jun 09, 2007 at 08:22:30PM +0200, Simon Bertrang wrote: > Hi, > when porting libapreq2 to OpenBSD we noticed a problem with a workaround > that doesn't apply anymore (APR.pm): > > $OpenBSD: patch-xs_APR_APR_APR_pm,v 1.1 2007/06/09 16:02:04 martynas Exp $ > --- xs/APR/APR/APR.pm.orig Mon Nov 20 01:31:02 2006 > +++ xs/APR/APR/APR.pm Sat Jun 9 18:10:04 2007 > @@ -23,7 +23,7 @@ our @ISA = qw(DynaLoader); > # XXX: see xs/ModPerl/Const/Const.pm for issues of using 0x01 > use Config (); > use constant DL_GLOBAL => > - ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' && $^O ne 'openbsd' ) ? 0x01 : 0x0; > + ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' ) ? 0x01 : 0x0; > sub dl_load_flags { DL_GLOBAL } > > unless (defined &APR::XSLoader::BOOTSTRAP) { > Here's a diff against svn. The second thing from my previous mail is fixed already as told by Jonathan Vanasco. Regards, Simon Index: xs/APR/APR/APR.pm =================================================================== --- xs/APR/APR/APR.pm (revision 545917) +++ xs/APR/APR/APR.pm (working copy) @@ -23,7 +23,7 @@ # XXX: see xs/ModPerl/Const/Const.pm for issues of using 0x01 use Config (); use constant DL_GLOBAL => - ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' && $^O ne 'openbsd' ) ? 0x01 : 0x0; + ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' ) ? 0x01 : 0x0; sub dl_load_flags { DL_GLOBAL } unless (defined &APR::XSLoader::BOOTSTRAP) { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org