perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe M. Chiasson" <go...@ectoplasm.org>
Subject Re: [PATCH]Re: segfault analysis
Date Mon, 07 May 2007 17:19:30 GMT
Torsten Foertsch wrote:
> On Sunday 06 May 2007 19:11, Torsten Foertsch wrote:
>> [...]
> 
> That happens if there is no handler configured at startup time but more than 
> one for the same phase at request time.

         if (ravp && !*ravp) {
+	    /* initialize ravp either from avp or as an empty array */
             if (*avp) {
                 /* merge with existing configured handlers */
                 *ravp = apr_array_copy(p, *avp);
@@ -437,6 +438,9 @@
                 *ravp = modperl_handler_array_new(p);
             }
         }
+        else if (ravp /* && *ravp */) {
+	    /* ravp is already initialized: do nothing */
+        }
         else if (!*avp) {


Wouldn't something like:

if (ravp && !*ravp) {

}

if (avp && !*avp) {

}

Be more concise ?

------------------------------------------------------------------------
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/


Mime
View raw message