perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randy Kobes <ra...@theoryx5.uwinnipeg.ca>
Subject Re: [PATCH] Re: [ANNOUNCE] mod_perl 1.30
Date Mon, 02 Apr 2007 00:26:43 GMT
On Fri, 30 Mar 2007, Steve Hay wrote:

> Philippe M. Chiasson wrote:
>> The URL
>>
>>   http://apache.org/dyn/closer.cgi/perl/mod_perl-1.30.tar.gz
>>   or
>>   http://www.perl.com/CPAN/modules/by-module/Apache/mod_perl-1.30.tar.gz
>> 
>> has entered CPAN
>
> I noticed that this doesn't build with a perl-5.8.8 system on Win32 because 
> the patch that was posted in the thread below was never applied:
>
> http://marc.info/?l=apache-modperl-dev&m=113999605514796&w=2
>
> I've attached a new patch against mod_perl-1.30 for the same issue.

Thanks, Steve, and sorry for not applying the earlier one.
At the time I wanted to check to see how that affected
perls, and then time slipped away ... This is now in svn,
with it applying for perl >= 5.8.6.

> However, something else now seems to be amiss too because after applying that 
> patch and then building mod_perl-1.30 I find that "nmake test" doesn't do 
> anything: it spits out the following lines (only) and then hangs until I 
> Ctrl+C it:

This seems to be a result from some white space added in
the generated Makefile - does the attached patch work?
Also, as I don't have Apache/1.3 on Unix, could someone
try this out there to make sure it's OK? Thanks.

=======================================================
Index: Makefile.PL
===================================================================
--- Makefile.PL	(revision 524700)
+++ Makefile.PL	(working copy)
@@ -178,7 +178,7 @@
  write_version_h("src/modules/perl");

  my(@test_pre_init) = qq(
-  test_pre_init:
+test_pre_init:
  );

  # Automatic setup support
@@ -1540,10 +1540,10 @@

      join '', @test_pre_init,
          qq(
-    MP_TEST_SCRIPT=$script
+MP_TEST_SCRIPT=$script
  ),
      q(
-    TEST_VERBOSE=0
+TEST_VERBOSE=0

  kill_httpd:
  	kill `cat t/logs/httpd.pid`

====================================================

-- 
best regards,
Randy
Mime
View raw message