perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <torsten.foert...@gmx.net>
Subject Re: mp2 segfault
Date Tue, 13 Mar 2007 20:25:14 GMT
On Tuesday 13 March 2007 10:05, Torsten Foertsch wrote:
> I have found a reproducible way to segfault a mod_perled httpd.

Sorry for the private posting but I need advice from the person who has 
implemented the worker mpm stuff in modperl particularly the "InterpScope 
handler" stuff. I think that bit is not very well covered by the test suite.

So, the simple patch below solves my problem. No segfaults so far. But is it 
right?

I have tested it with ab and several million requests and no memory leak 
detected. The test suite is also passed. But that doesn't mean anything. I 
have grepped t for "interpscope handler" without success.

Torsten

--- src/modules/perl/modperl_interp.c~  2006-11-20 00:30:59.000000000 +0100
+++ src/modules/perl/modperl_interp.c   2007-03-13 20:57:57.000000000 +0100
@@ -286,6 +286,7 @@
         MP_dRCFG;
         modperl_config_request_cleanup(interp->perl, r);
         MpReqCLEANUP_REGISTERED_Off(rcfg);
+        interp->request=NULL;
     }

     MpInterpIN_USE_Off(interp);


Mime
View raw message