perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikolay Ananiev" <anan...@thegdb.com>
Subject Cygwin and apache/daemon.t
Date Thu, 05 Oct 2006 16:13:30 GMT
In present days, Cygwin behaves more like a traditional unix system.
Thats why some of the old workarounds in mp2's build and test system
are not applicable anymore. The following patch removes these workarounds.
With the patch all tests complete successfuly on perl 5.8.7, Apache 2.2.2.


Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
--- Apache-Test/lib/Apache/TestConfig.pm (revision 453124)
+++ Apache-Test/lib/Apache/TestConfig.pm (working copy)
@@ -23,7 +23,7 @@
 use constant CYGWIN  => $^O eq 'cygwin';
 use constant NETWARE => $^O eq 'NetWare';
 use constant SOLARIS => $^O eq 'solaris';
-use constant WINFU   => WIN32 || CYGWIN || NETWARE;
+use constant WINFU   => WIN32 || NETWARE;
 use constant COLOR   => ($ENV{APACHE_TEST_COLOR} && -t STDOUT) ? 1 : 0;

 use constant DEFAULT_PORT => 8529;
@@ -1589,7 +1589,7 @@

     $self->preamble_run($out);

-    for my $name (qw(user group)) { #win32/cygwin do not support
+    for my $name (qw(user group)) { # win32 does not support
         if ($vars->{$name}) {
             print $out qq[\u$name    "$vars->{$name}"\n];
         }
Index: t/response/TestApache/daemon.pm
===================================================================
--- t/response/TestApache/daemon.pm (revision 453124)
+++ t/response/TestApache/daemon.pm (working copy)
@@ -11,7 +11,7 @@
 use Apache::TestUtil;
 use Apache::Test;

-use constant WIN32 => Apache::TestConfig::WIN32 ||
Apache::TestConfig::CYGWIN;
+use constant WIN32 => Apache::TestConfig::WIN32;

 use Apache2::Const -compile => 'OK';








---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message