perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: [Fwd: Re: mp2: push_handlers / set_handlers vs. Perl*Handler]
Date Fri, 15 Sep 2006 16:00:45 GMT

> Geoff, the patch you gave me passed, which is good.  I have adjusted the
> patch so that it replicates the problem that Jeremy and I both ran into. 

sweet.

> The specific problem seems to be that push_handlers doesn't behave as it
> should when pushing a FixupHandler from a PostReadRequestHandler, if I am
> understanding how this test works.  The fixup handler gets pushed ok, but
> it seems to remove the existing Fixup handlers.  Let me know if you want
> me test this another way, it's possible that I'm not fully grokking the
> test magic here but I think I get it.

looks good to me.

because we're in the middle of a release cycle, let's hold off on
committing this until 2.0.3 is released.  once philip releases and bumps
the version, feel free to commit the new test so we can work on a fix.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message