perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: THE PLAN 2.0.3
Date Thu, 07 Sep 2006 05:01:15 GMT
Philip M. Gollucci wrote:
> Hi all,
> 
> After some deep thought, here's whats going to happen:
> 
> svn trunk:
>   Apache-SizeLimit integration is going to be rolled back to
>   http://svn.apache.org/viewvc/perl/modperl/tags/before_apache_sizelimit_integration
>   This tag is then going to be deleted.
Done.

> 
> I'll then start the Release process for 2.0.3 as the RM (assuming everything works, if
not, I'll fix it)
> and post -RC1 later TODAY.
Is anyone else seeing t/modperl/pnotes.t fail test 27 ?
BUT, only without LWP installed ?

Works with it.

So my first thought was I tried reverting _ALL_ my recent changes to Apache-Test/lib/Apache/TestClient.pm
-- that didn't
help, but it does rule that out as the problem. (svn up -r365788 TestClient.pm)

It does however work in 2.0.2 without LWP.

With LWP:
GET /TestModperl__pnotes?1 HTTP/1.1
TE: deflate,gzip;q=0.3
Keep-Alive: 300
Connection: Keep-Alive, TE
Host: localhost:8529
User-Agent: libwww-perl/5.805

Without LWP:
GET http://localhost:8529/TestModperl__pnotes?1 HTTP/1.0
User-Agent: libwww-perl/0.00
Host: localhost

So obviously its because The Keep-Alive header isn't getting set.
The problem must be in Apache/TestRequest::user_agent() and what ends up in Apache/TestClient::request(,,@headers)
based on
Apache::TestRequest::user_agent(reset => 1, keep_alive => 1);

Looking at Apache/TestRequest::new()
#subclass LWP::UserAgent
sub new {

    my $self = shift->SUPER::new(@_);

$self actually comes back as undef because
@ISA = qw(LWP::UserAgent);

AND its not there to had.


I fully concur it shouldn't work without LWP -- I just can't figure out why it works in 2.0.2
My solution unless someone speaks up will be to require LWP for this test.

AFAIK, this is my only hold on these:

	Apache-Test-1.29-RC1
	mod_perl-2.0.3-RC1
	libapreq2-2.09-RC1


-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /
 / /|_/ / // /\ \/ /_/ / /__
/_/  /_/\_, /___/\___\_\___/
       <___/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message