perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: 'error-notes' has no value on errordocument redirect (patch and tests attached)
Date Wed, 23 Aug 2006 03:48:19 GMT
Guy Albertelli II wrote:
> +open(my $fh,'>/tmp/test');
That should be File::tmpdir() / catfile() functions
to build that path.

> +    &bomb();
Don't need the &

> +    Apache2::Const::OK;
> +}
> +
> +sub fail {
> +    my $r = shift;
Needs a line break here to match our style guide.

I'll get around to running this in a bit, but from an eyeball perspective, it looks good.

Thanks Guy.

-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /
 / /|_/ / // /\ \/ /_/ / /__
/_/  /_/\_, /___/\___\_\___/
       <___/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message