Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 74057 invoked from network); 6 Jul 2006 14:03:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2006 14:03:04 -0000 Received: (qmail 1272 invoked by uid 500); 6 Jul 2006 14:03:04 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 1263 invoked by uid 500); 6 Jul 2006 14:03:04 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 1247 invoked by uid 99); 6 Jul 2006 14:03:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2006 07:03:04 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of autarch@urth.org designates 65.103.28.217 as permitted sender) Received: from [65.103.28.217] (HELO urth.org) (65.103.28.217) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Jul 2006 07:03:03 -0700 Received: from autarch (helo=localhost) by urth.org with local-esmtp (Exim 4.60) (envelope-from ) id 1FyURG-0004Kf-C1 for dev@perl.apache.org; Thu, 06 Jul 2006 09:02:42 -0500 Date: Thu, 6 Jul 2006 09:02:41 -0500 (CDT) From: Dave Rolsky To: dev@perl.apache.org Subject: Re: svn commit: r419251 - /perl/Apache-SizeLimit/trunk/Makefile.PL In-Reply-To: <44ACD1B1.103@p6m7g8.com> Message-ID: References: <20060705151424.224561A981A@eris.apache.org> <44ACD1B1.103@p6m7g8.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On Thu, 6 Jul 2006, Philip M. Gollucci wrote: > autarch@apache.org wrote: >> -sub MY::postamble { >> +package MY; >> + >> +sub postamble { >> my $self = shift; >> -sub MY::test { >> +sub test { >> -sub MY::clean { >> +sub clean { > > While that works, Its not consistent with any of our other Makefile.PL's do we want to be consistent, or does it not > matter ? I can't call SUPER:: without having the code be in a defined package. I'd prefer to have it call SUPER:: rather than hard-coding a particular package, it's just cleaner. -dave /*=================================================== VegGuide.Org www.BookIRead.com Your guide to all that's veg. My book blog ===================================================*/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org