Return-Path: Delivered-To: apmail-perl-dev-archive@www.apache.org Received: (qmail 80900 invoked from network); 17 Jul 2006 17:07:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Jul 2006 17:07:12 -0000 Received: (qmail 64945 invoked by uid 500); 17 Jul 2006 17:07:12 -0000 Delivered-To: apmail-perl-dev-archive@perl.apache.org Received: (qmail 64769 invoked by uid 500); 17 Jul 2006 17:07:11 -0000 Mailing-List: contact dev-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@perl.apache.org Received: (qmail 64758 invoked by uid 99); 17 Jul 2006 17:07:11 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 10:07:11 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [66.236.219.70] (HELO piccollo.p6m7g8.net) (66.236.219.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2006 10:07:09 -0700 Received: from [172.28.57.204] (office4.tmcs.net [209.104.55.5]) (authenticated bits=0) by piccollo.p6m7g8.net (8.13.6/8.13.6) with ESMTP id k6HH6jBd028692 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO); Mon, 17 Jul 2006 13:06:47 -0400 (EDT) (envelope-from pgollucci@p6m7g8.com) Message-ID: <44BBC39D.2080309@p6m7g8.com> Date: Mon, 17 Jul 2006 10:06:37 -0700 From: "Philip M. Gollucci" Organization: P6M7G8 Inc. User-Agent: Thunderbird 1.5.0.4 (X11/20060716) MIME-Version: 1.0 To: Dave Rolsky CC: dev@perl.apache.org Subject: Re: Apache::SizeLimit - iffied for mp2 References: <44BB6161.9050804@p6m7g8.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N > something like Apache::SizeLimit::Base or something like that. That crossed my mind... > - Rather than inlining both bits of code in the handler(), I'd rather > see that in separate subs. Hmm.... > - Doesn't a method handled in mp2 need a ": method" attribute? Yes.. > > - You import DECLINED so why fully qualify it everywhere? You've got to do it this way or you get warnings galour. > - I think import() should be called as a direct class method (style nit). Agreed. I copied that from somewhere. -- ------------------------------------------------------------------------ Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708 Consultant / http://p6m7g8.net/Resume/resume.shtml Senior Software Engineer - TicketMaster - http://ticketmaster.com 1024D/A79997FA F357 0FDD 2301 6296 690F 6A47 D55A 7172 A799 97F "It takes a minute to have a crush on someone, an hour to like someone, and a day to love someone, but it takes a lifetime to forget someone..." --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org For additional commands, e-mail: dev-help@perl.apache.org