perl-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: Apache::SizeLimit Error
Date Tue, 01 Aug 2006 01:01:39 GMT
David Wheeler wrote:
> --- lib/Apache/SizeLimit.pm.old 2006-07-31 14:11:48.000000000 -0700
> +++ lib/Apache/SizeLimit.pm     2006-07-31 14:12:11.000000000 -0700
> @@ -92,7 +92,7 @@
>      # PerlCleanupHandler phase. That means that there's no way to use
>      # $r->get_handlers() to check the results of calling this method.
>      $r->push_handlers( 'PerlCleanupHandler',
> -                       sub { $class->_exit_if_too_big() } );
> +                       sub { $class->_exit_if_too_big(shift) } );
>      $r->pnotes( size_limit_cleanup => 1 );
> }
sub add_cleanup_handler {
     my $class = shift;
     my $r = shift || Apache->request;

Wny not just pass the $r that we have ?
(I agree with the spirit of the patch)

I'll commit a tweaked version tomorrowish unless someone screams.

-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"It takes a minute to have a crush on someone, an hour to like someone,
and a day to love someone, but it takes a lifetime to forget someone..."

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Mime
View raw message